Last modified: 2014-07-09 08:58:39 UTC
We currently have browser tests for two of the Mediawiki preferences tabs: * Appearance: https://github.com/wikimedia/qa-browsertests/blob/master/features/preferences_appearance.feature * Date and Time: https://github.com/wikimedia/qa-browsertests/blob/master/features/preferences_datetime.feature We should add a new browser test (in the same repo) for the "Gadgets" tab, to make sure that all expected page elements are present with each release (i.e. make sure we don't create any regressions!).
Change 103411 had a related patch set uploaded by Mayankmadan: Additional browsertest for gadgets tab in preferences https://gerrit.wikimedia.org/r/103411
Change 103411 abandoned by Mayankmadan: Additional browsertest for gadgets tab in preferences Reason: Not working on this anymore https://gerrit.wikimedia.org/r/103411
Would Mayank's patch in https://gerrit.wikimedia.org/r/103411 be something to continue on for a new contributor?
Andre, I do not think that the patch contains code that a new contributor could use.
Change 117088 had a related patch set uploaded by Vikassy: Added browser test for Preferences Gadgets tab https://gerrit.wikimedia.org/r/117088
(In reply to Jeff Hall from comment #0) > We currently have browser tests for two of the Mediawiki preferences tabs: > > * Appearance: > https://github.com/wikimedia/qa-browsertests/blob/master/features/ > preferences_appearance.feature > * Date and Time: > https://github.com/wikimedia/qa-browsertests/blob/master/features/ > preferences_datetime.feature > > We should add a new browser test (in the same repo) for the "Gadgets" tab, > to make sure that all expected page elements are present with each release > (i.e. make sure we don't create any regressions!). How useful is this test? Do we really care if a checkbox is on the page? If a gadget is broken or removed, will the checkbox be automatically removed? Also, gadgets are not the same at en.wikipedia.beta.wmflabs.org and test2.wikipedia.org. Do we need to check gadgets at just one site, or both?
Resolving wontfix because of the last two comments on the related commit: https://gerrit.wikimedia.org/r/#/c/117088/ Zfilipin Jun 30 10:04 AM Patch Set 7: Code-Review-2 This commit should be moved to mediawiki/core: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/core Cmcmahon Jun 30 5:57 PM Patch Set 7: Code-Review-2 This build should not be moved to /mediawiki/core. Tests in core should always pass on a bare wiki, and a bare wiki has no Gadgets tab.
Change 117088 abandoned by Zfilipin: Added browser test for Preferences Gadgets tab Reason: We no longer have a repository where this commit would go. https://gerrit.wikimedia.org/r/117088
