Last modified: 2013-12-20 17:03:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60705, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58705 - Flow is breaking OAuth login
Flow is breaking OAuth login
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Immediate blocker (vote)
: ---
Assigned To: Nobody - You can work on this!
https://tools.wmflabs.org/gerrit-patc...
:
: 58708 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-19 19:50 UTC by Strainu
Modified: 2013-12-20 17:03 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Strainu 2013-12-19 19:50:15 UTC
I currently get a 500 error when trying to login in the gerrit uploader. This basically makes the uploader useless.
Comment 1 Merlijn van Deen (test) 2013-12-19 20:00:40 UTC
Local testing shows mediawiki.org returning "Our servers are currently experiencing a technical problem.".

So, two problems here: mw.org is throwing an error (which should be fixed soon), and the patch uploader 500's instead of showing a sensible error message. For the second one: https://github.com/valhallasw/gerrit-patch-uploader/issues/12
Comment 2 Brad Jorsch 2013-12-19 20:02:13 UTC
It's a repeat of bug 58380, this time Flow's fault:

[19-Dec-2013 19:57:46] Fatal error: Call to a member function isSpecial() on a non-object at /usr/local/apache/common-local/php-1.23wmf8/extensions/OAuth/api/MWOAuthAPI.setup.php on line 55
Server: mw1017
Method: POST
URL: http://test.wikipedia.org/w/api.php
Backtrace:
#0 /usr/local/apache/common-local/php-1.23wmf8/extensions/OAuth/api/MWOAuthAPI.setup.php(55): MWOAuthAPISetup::getOAuthAccessToken()
#1 /usr/local/apache/common-local/php-1.23wmf8/extensions/OAuth/api/MWOAuthAPI.setup.php(89): MWOAuthAPISetup::getOAuthAccessToken()
#2 [internal function]: MWOAuthAPISetup::onUserLoadFromSession(Object(User), NULL)
#3 /usr/local/apache/common-local/php-1.23wmf8/includes/Hooks.php(199): call_user_func_array('MWOAuthAPISetup...', Array)
#4 /usr/local/apache/common-local/php-1.23wmf8/includes/GlobalFunctions.php(4031): Hooks::run('UserLoadFromSes...', Array)
#5 /usr/local/apache/common-local/php-1.23wmf8/includes/User.php(935): wfRunHooks('UserLoadFromSes...', Array)
#6 /usr/local/apache/common-local/php-1.23wmf8/includes/User.php(297): User->loadFromSession()
#7 /usr/local/apache/common-local/php-1.23wmf8/includes/User.php(4560): User->load()
#8 /usr/local/apache/common-local/php-1.23wmf8/includes/User.php(2312): User->loadOptions()
#9 /usr/local/apache/common-local/php-1.23wmf8/includes/context/RequestContext.php(333): User->getOption('language')
#10 /usr/local/apache/common-local/php-1.23wmf8/includes/StubObject.php(204): RequestContext->getLanguage()
#11 /usr/local/apache/common-local/php-1.23wmf8/includes/StubObject.php(149): StubUserLang->_newObject()
#12 /usr/local/apache/common-local/php-1.23wmf8/includes/StubObject.php(98): StubObject->_unstub('getDir', 5)
#13 /usr/local/apache/common-local/php-1.23wmf8/includes/StubObject.php(197): StubObject->_call('getDir', Array)
#14 /usr/local/apache/common-local/php-1.23wmf8/extensions/Flow/includes/Notifications/Controller.php(32): StubUserLang->__call('getDir', Array)
#15 /usr/local/apache/common-local/php-1.23wmf8/extensions/Flow/includes/Notifications/Controller.php(32): StubUserLang->getDir()
#16 /usr/local/apache/common-local/php-1.23wmf8/extensions/Flow/Hooks.php(15): Flow\NotificationController->setup()
#17 [internal function]: FlowHooks::initFlowExtension()
#18 /usr/local/apache/common-local/php-1.23wmf8/includes/Setup.php(602): call_user_func('FlowHooks::init...')
#19 /usr/local/apache/common-local/php-1.23wmf8/includes/WebStart.php(153): require_once('/usr/local/apac...')
#20 /usr/local/apache/common-local/php-1.23wmf8/api.php(44): require('/usr/local/apac...')
#21 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')
#22 {main}
Comment 3 Oliver Keyes 2013-12-19 20:03:39 UTC
Poking the engineers.
Comment 4 Sam Reed (reedy) 2013-12-19 20:03:44 UTC
*** Bug 58708 has been marked as a duplicate of this bug. ***
Comment 5 Gerrit Notification Bot 2013-12-19 20:40:52 UTC
Change 102750 had a related patch set uploaded by Spage:
Allow icon paths to be resolved when requested

https://gerrit.wikimedia.org/r/102750
Comment 6 Gerrit Notification Bot 2013-12-19 22:29:48 UTC
Change 102783 had a related patch set uploaded by Spage:
Allow defining clousre for notification icon path

https://gerrit.wikimedia.org/r/102783
Comment 7 Gerrit Notification Bot 2013-12-19 22:30:54 UTC
Change 102783 merged by jenkins-bot:
Allow defining clousre for notification icon path

https://gerrit.wikimedia.org/r/102783
Comment 8 Gerrit Notification Bot 2013-12-19 23:27:34 UTC
Change 102750 abandoned by EBernhardson:
Allow icon paths to be resolved when requested

Reason:
abandon in favor of https://gerrit.wikimedia.org/r/102834

https://gerrit.wikimedia.org/r/102750
Comment 9 Gerrit Notification Bot 2013-12-20 00:16:38 UTC
Change 102855 had a related patch set uploaded by Bsitu:
Allow icons to set different ltr/rtl versions

https://gerrit.wikimedia.org/r/102855
Comment 10 Gerrit Notification Bot 2013-12-20 00:24:13 UTC
Change 102855 merged by jenkins-bot:
Allow icons to set different ltr/rtl versions

https://gerrit.wikimedia.org/r/102855
Comment 11 Gerrit Notification Bot 2013-12-20 00:27:10 UTC
Change 102851 had a related patch set uploaded by Spage:
Add rtl and ltr icons for flow notification

https://gerrit.wikimedia.org/r/102851
Comment 12 Gerrit Notification Bot 2013-12-20 00:27:41 UTC
Change 102851 merged by jenkins-bot:
Add rtl and ltr icons for flow notification

https://gerrit.wikimedia.org/r/102851
Comment 13 Gerrit Notification Bot 2013-12-20 00:51:24 UTC
Change 102861 had a related patch set uploaded by Spage:
Update Echo and Flow

https://gerrit.wikimedia.org/r/102861
Comment 14 Gerrit Notification Bot 2013-12-20 00:59:14 UTC
Change 102861 merged by jenkins-bot:
Update Echo and Flow.

https://gerrit.wikimedia.org/r/102861
Comment 15 Brad Jorsch 2013-12-20 17:03:26 UTC
This appears to be fixed now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links