Last modified: 2013-12-30 21:49:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60326, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58326 - Update favicon wiktionary/en.ico
Update favicon wiktionary/en.ico
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Geoffrey Mon
http://www.google-melange.com/gci/tas...
:
: 58523 (view as bug list)
Depends on:
Blocks: 45036
  Show dependency treegraph
 
Reported: 2013-12-11 13:34 UTC by Aditya Gulati
Modified: 2013-12-30 21:49 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
32x32 size (4.19 KB, image/x-icon)
2013-12-11 13:34 UTC, Aditya Gulati
Details
16x16 size (1.12 KB, patch)
2013-12-11 13:36 UTC, Aditya Gulati
Details
48x48 size (9.43 KB, patch)
2013-12-11 13:37 UTC, Aditya Gulati
Details

Description Aditya Gulati 2013-12-11 13:34:31 UTC
Created attachment 14058 [details]
32x32 size

Create a favicon including 16x16, 32x32, and 48x48 versions of https://upload.wikimedia.org/wikipedia/commons/3/35/Simple_Wiktionary_logo.png. Substitute wiktionary/en.ico at operations/mediawiki-config/docroot/bits/favicon with the new version.
Comment 1 Aditya Gulati 2013-12-11 13:36:48 UTC
Created attachment 14059 [details]
16x16 size
Comment 2 Aditya Gulati 2013-12-11 13:37:29 UTC
Created attachment 14060 [details]
48x48 size
Comment 3 Quim Gil 2013-12-11 15:29:44 UTC
Hello Aditya, please follow the instructions of the Google Code-in task.

What we are looking for is one single favicon with three layers contributed as a Gerrit changeset.

As an example, check Bug 58144 and its related https://gerrit.wikimedia.org/r/100133

You have links with information about Git and Gerrit at https://www.mediawiki.org/wiki/Google_Code-In

Thank you!
Comment 4 MZMcBride 2013-12-14 21:36:45 UTC
Given comment 3, I'm presuming that this bug is not unconfirmed.
Comment 5 Quim Gil 2013-12-16 03:50:51 UTC
*** Bug 58523 has been marked as a duplicate of this bug. ***
Comment 6 Quim Gil 2013-12-16 05:16:43 UTC
Hi Adit, 

(In reply to bug 58523 comment #2)
> Since I have the .ico made, should I just make a pull request to the main
> public repo so that it will be uploaded to the main project?

You must submit a patch via Gerrit, specifying in the commit message the bug report you are solving. See for example bug 58122 and its related https://gerrit.wikimedia.org/r/#/c/99756/

A pull request in GitHub is not bad for a first try but we are expecting the patch to follow the Gerrit review process that we apply to all our contributions. If you are not familiar with Gerrit you can check the tutorial and other interesting links at 

https://www.mediawiki.org/wiki/Google_Code-In#Suggested_reading

We hope to see the link to your patch for review soon!
Comment 7 Gerrit Notification Bot 2013-12-18 06:16:33 UTC
Change 102386 had a related patch set uploaded by Aquifacae:
Changed wiktionary/en.ico favicon to proper image and resolutions

https://gerrit.wikimedia.org/r/102386
Comment 8 Gerrit Notification Bot 2013-12-18 20:58:05 UTC
Change 102386 abandoned by Aquifacae:
Changed wiktionary/en.ico favicon to proper image and resolutions

Reason:
Decided not to use this image for favicon

https://gerrit.wikimedia.org/r/102386
Comment 9 Gerrit Notification Bot 2013-12-18 21:07:05 UTC
Change 102554 had a related patch set uploaded by Aquifacae:
Added new 48x48 resolution to original favicon

https://gerrit.wikimedia.org/r/102554
Comment 10 Gerrit Notification Bot 2013-12-19 00:17:58 UTC
Change 102554 abandoned by Aquifacae:
Added new 48x48 resolution to wiktionary/en favicon

https://gerrit.wikimedia.org/r/102554
Comment 11 Gerrit Notification Bot 2013-12-19 00:21:59 UTC
Change 102602 had a related patch set uploaded by Aquifacae:
Made proper larger favicon wiktionary/en.ico favicon.

https://gerrit.wikimedia.org/r/102602
Comment 12 Gerrit Notification Bot 2013-12-19 21:50:50 UTC
Change 102602 abandoned by Aquifacae:
Made proper larger favicon wiktionary/en.ico.

https://gerrit.wikimedia.org/r/102602
Comment 13 Gerrit Notification Bot 2013-12-21 21:02:18 UTC
Change 103183 had a related patch set uploaded by Sn1per:
Fix en.wiktionary favicon for GCI 2013

https://gerrit.wikimedia.org/r/103183
Comment 14 Gerrit Notification Bot 2013-12-30 21:48:39 UTC
Change 103183 merged by jenkins-bot:
Fix en.wiktionary favicon

https://gerrit.wikimedia.org/r/103183

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links