Last modified: 2014-01-30 01:54:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60297, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58297 - Implement new mediawiki.ui button appearance in core
Implement new mediawiki.ui button appearance in core
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 58296 mediawiki.ui
  Show dependency treegraph
 
Reported: 2013-12-10 23:31 UTC by Matthew Flaschen
Modified: 2014-01-30 01:54 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-12-10 23:31:50 UTC
There is a new in-progress design/UX for the mediawiki.ui buttons: https://www.mediawiki.org/wiki/File:Agora_specs.pdf .  This includes a new appearance and different CSS class names (see http://www.mail-archive.com/design@lists.wikimedia.org/msg00011.html and https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Agora_Control_Library/Behavior).

These updated styles and class names need to be implemented in core.  This blocks bug 54360, but can be done before bigger parts of that (e.g. mediawiki.ui dialogs).
Comment 1 Jared Zimmerman (WMF) 2013-12-11 04:07:09 UTC
We should also do an audit of where Primary should be Constructive and where is should be Progressive. Ideally we'd flip the switch on wikimedia.org first and make changes there so they'll be correct when they go to wikipedia. Should this be a separate bug?
Comment 2 Matthew Flaschen 2013-12-11 05:04:52 UTC
We can reuse https://gerrit.wikimedia.org/r/#/c/52169 , since it's basically the same thing (albeit started before the new class names were developed).

I suggest we test on Labs (with that changeset checked out), then roll out with the normal process (https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap).  We can set up a new Labs instance if none of the current ones are suitable.
Comment 3 Matthew Flaschen 2013-12-11 05:13:15 UTC
As far as separate bugs, I guess it depends on how we break it up.  If we do it all in two commits:

1. Update core styles and class names and the existing uses in core (there aren't many mw.ui buttons in core, so updating the class names in the HTML is not complicated)
2. Add mw.ui button classes to the remainder of core.

we should make a separate bug for #2 at some point.
Comment 4 Matthew Flaschen 2013-12-11 05:14:40 UTC
With that strategy, https://gerrit.wikimedia.org/r/#/c/52169 would be for #2.
Comment 5 Gerrit Notification Bot 2013-12-23 21:58:09 UTC
Change 103494 had a related patch set uploaded by JGonera:
[WIP] Update mediawiki.ui button styles

https://gerrit.wikimedia.org/r/103494
Comment 6 Gerrit Notification Bot 2013-12-27 09:10:24 UTC
Change 104011 had a related patch set uploaded by Spage:
[WIP] Update login and HTMLForm to new design

https://gerrit.wikimedia.org/r/104011
Comment 7 Gerrit Notification Bot 2014-01-29 19:29:22 UTC
Change 103494 merged by jenkins-bot:
Update mediawiki.ui button styles

https://gerrit.wikimedia.org/r/103494

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links