Last modified: 2013-12-19 19:18:16 UTC
Create a favicon including 16x16, 32x32, and 48x48 versions of [URL of the high-resolution logo]. Substitute community.ico at operations/mediawiki-config/docroot/bits/favicon with the new version.
A little problem, the .ico file on the favicom seems to be corrupted. I can not open it.
I cannot open it either. I guess the ico refers to https://commons.wikimedia.org/wiki/File:Wikimedia_Community_Logo.svg ?
I have no problems opening the file, but yes, it can be created anew from the SVG version of the community logo (or an exported PNG, whichever you prefer) that Quim linked in comment 2.
Created attachment 14029 [details] Community.ico update
Can you subbmit this attachment to Gerrit please?
Vlad John reported problems installing git-review, see the GCI task for details. I haven't used gerrit-review in Windows, neither Gerrit without gerrit-review. Another option that comes to mind is to submit the patch via https://github.com/wikimedia/operations-mediawiki-config Any ideas? Committing the patch (as opposed to simply attach the file here is indeed part of the task (since GCI is about learning, and code review is an interesting skill to learn).
Ah wait. Vlad, you can use https://tools.wmflabs.org/gerrit-patch-uploader/
(In reply to comment #6) > Vlad John reported problems installing git-review, see the GCI task for > details. I haven't used gerrit-review in Windows, neither Gerrit without > gerrit-review. I haven't used Windows in a while, so can't comment on that, but it's possible to submit commits to Gerrit without git-review using https://www.mediawiki.org/wiki/Gerrit/Alternatives_to_git-review > Another option that comes to mind is to submit the patch via > https://github.com/wikimedia/operations-mediawiki-config YuviPanda's SuchABot isn't enabled on this repo, so you'd have to submit all Github pull requests by hand, which is a terrible terrible "solution".
I tried to upload the patch using this site: tools.wmflabs.org/gerrit-patch-uploader/ , but got this error: Upload failed Reason: Patch failed (is your patch in unified diff format, and does it patch apply cleanly to master?) (check log above for details) How should I create the patch file, and in what format? (I tried both an .ico file and a .diff file)
Hi Vlad, as commented in the GCI task already: The error message tells you that you need to submit a "patch in unified diff format" that can be applied "cleanly to master". Please detail at the bug report the command line instructions you are using to generate the diff file and the replies you are getting for each step. This way we can tell you whether you are doing something wrong.
I am using a program for windows called UnxUtils... The command i write looks like this: diff -u oldfile newfile > patchfile But it says diff:command not found. I also tried to use WinMerge, where I opened the .ico file from the site, and the .ico file I created, and then in the Tools menu, I used Create patch, but it said I coukd not create a patch from the binarry.
Please us git. GCI is about learning. If you want to be a developer you must learn git. :)
Change 102586 had a related patch set uploaded by RashiqAhmad: Updated community.ico https://gerrit.wikimedia.org/r/102586
Change 102586 merged by jenkins-bot: Updated community.ico https://gerrit.wikimedia.org/r/102586
