Last modified: 2014-03-11 14:09:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59746, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57746 - Allow Entity pages to be stored in the ParserCache
Allow Entity pages to be stored in the ParserCache
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
: i18n, performance
Depends on: 58342 58344
Blocks: 54098
  Show dependency tree / graph
 
Reported: 2013-11-29 15:16 UTC by Daniel Kinzler
Modified: 2014-03-11 14:09 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2013-11-29 15:16:49 UTC 
Since the rendering of Entity pages depend on the user's language, even for anonymous users, they are currently not cached. This is a big performance issue.

MediaWiki usually forces the parser cache key for anonymous visitors to 'canonical'. This should be overwritten for Wikibase, and a cache key should be generated based on the user preferences, just like for logged in users.

On a related note, we could try to avoid MediaWiki parsing and caching pages directly upon saving them, since it's unclear which cache key is used for that, and it seems pointless for bot edits.
Comment 1 Gerrit Notification Bot 2013-12-02 13:19:48 UTC 
Change 98511 had a related patch set uploaded by Daniel Kinzler:
(bug 57746) Allow entity pages to use parser cache

https://gerrit.wikimedia.org/r/98511
Comment 2 Gerrit Notification Bot 2013-12-03 13:09:25 UTC 
Change 98511 merged by jenkins-bot:
(bug 57746) Allow entity pages to use parser cache

https://gerrit.wikimedia.org/r/98511
Comment 3 Daniel Kinzler 2013-12-11 19:03:08 UTC 
This was reverted on the deployment branch, due to several issues:

a) old parser cache "pointer" entries in the cache causing entity content in random languages to be shown. Should be solvable by bumping wgCacheEpoch when deploying.

b) The term box ("in other languages" section) is user-specific and can not be cached, see bug 58342

c) EntityView uses the language from the context object, instead of the language given by the parser options for generating output. See 58344
Comment 4 Nemo 2014-02-26 23:57:14 UTC 
(In reply to Daniel Kinzler from comment #0)
> MediaWiki usually forces the parser cache key for anonymous visitors to
> 'canonical'. This should be overwritten for Wikibase, and a cache key should
> be generated based on the user preferences, just like for logged in users.

Nice. Will this bring us any closer to having ULS language selection enabled for anonymous users (bug 56464 and friends)? This area would greatly use some atomic bug reports for each component of the issue...
Comment 5 Niklas Laxström 2014-02-27 08:36:37 UTC 
(In reply to Nemo from comment #4)
> Nice. Will this bring us any closer to having ULS language selection enabled
> for anonymous users (bug 56464 and friends)?

Nope. The problem is at front-end caching level.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links