Last modified: 2014-06-30 13:34:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59663, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 57663 - size of rank icon is different from value snak icon


Summary:	size of rank icon is different from value snak icon

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:	papercut
Keywords:

Depends on:
Blocks:	52136 49120
	Show dependency tree / graph

Reported:	2013-11-27 16:04 UTC by Lydia Pintscher
Modified:	2014-06-30 13:34 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Lydia Pintscher 2013-11-27 16:04:28 UTC

The icon that indicates the rank of a claim is different than the one that lets the user select no-value snak and so on. Since they are so close together they should be the same size.

Comment 1 Lydia Pintscher 2013-12-03 13:51:50 UTC

Here are two mockups for inspiration by SvenManguard:
* https://commons.wikimedia.org/wiki/File:Wikidata_unknwon_and_no_value_display_mockup.png
* https://commons.wikimedia.org/wiki/File:Wikidata_priority_mockups.png

Comment 2 Thiemo Mättig 2014-02-20 21:40:09 UTC

I suggest enlarging the SnakTypeSelector icon from the current 16x16 to 16x19 by simply adding a few pixel rows. It's to small anyway and hard to hit.

We could make it a sprite to save requests while at it.

I would love to take an fix this but I think it's more a low priority cosmetic issue. What do you think?

Comment 3 Gerrit Notification Bot 2014-03-22 12:01:45 UTC

Change 120201 had a related patch set uploaded by Thiemo Mättig (WMDE):
Slightly enlarge Snak type (custom/unknown/no value) icons

https://gerrit.wikimedia.org/r/120201

Comment 4 Gerrit Notification Bot 2014-06-03 21:26:26 UTC

Change 120201 merged by Hoo man:
Slightly enlarge Snak type (custom/unknown/no value) icons

https://gerrit.wikimedia.org/r/120201

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links