Last modified: 2014-06-20 22:02:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59205, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57205 - VisualEditor: Opening and closing the link inspector dirties the link, adding a pointless transaction
VisualEditor: Opening and closing the link inspector dirties the link, adding...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-06-12
Assigned To: Trevor Parscal
:
Depends on:
Blocks: ve-linkediting
  Show dependency tree / graph
 
Reported: 2013-11-18 18:55 UTC by Rummana Yasmeen
Modified: 2014-06-20 22:02 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2013-11-18 18:55:07 UTC 
Steps to reproduce:


1.Click on the edit button
2.Click on a link and click on the link insertion icon.
3.Without making any change just close the link inspector

Observed Result:
The "Save Page" button becomes active though if you review the changes it will say that this revision matches the lastest version of the page.

Expected Result:
If there is not modification in the content it is probably better to keep the "Save Changes" button inactive.

Sample Page:

https://en.wikipedia.org/w/index.php?title=Tea_tree_oil&veaction=edit

Browser: Chrome Version 26.0.1410.65
Comment 1 James Forrester 2013-11-19 06:14:32 UTC 
Instead we should check to see if the new annotation is actually different before applying it.
Comment 2 James Forrester 2014-06-12 04:59:07 UTC 
Now fixed by Trevor's work on the link inspector and window transactions.
Comment 3 Rummana Yasmeen 2014-06-13 21:17:12 UTC 
Verified the fix in test2 running wmf 9
Comment 4 Rummana Yasmeen 2014-06-20 22:02:00 UTC 
Verified the fix in production (en.wiki)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links