Last modified: 2013-11-26 12:11:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59056, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57056 - Flow: Change logging to LifecycleHandler
Flow: Change logging to LifecycleHandler
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 57055
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-14 15:41 UTC by Matthias Mullie
Modified: 2013-11-26 12:11 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthias Mullie 2013-11-14 15:41:48 UTC
To save log entries, Topic.php will do a $logger->log() call. It'd be better to have logging work similar to RC (Flow\Data\RecentChanges)

This was initially not possible, because:

* moderation notes are needed in log, but not saved in revision object (see bug 57055)
* action names were not accessible

The latter has already been addressed; AbstractRevision::getChangeType() should return an action name that is known by FlowActions, so the relevant logging data ('log_type') can be fetched.

Once bug 57055 is resolved, we should probably be able to improve this.
Comment 1 spage 2013-11-14 18:30:07 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/462, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Gerrit Notification Bot 2013-11-18 05:21:02 UTC
Change 95985 had a related patch set uploaded by Werdna:
[SCHEMA CHANGE] Refactor of moderation logging.

https://gerrit.wikimedia.org/r/95985
Comment 3 Gerrit Notification Bot 2013-11-26 12:10:39 UTC
Change 95985 merged by jenkins-bot:
[SCHEMA CHANGE] Refactor of moderation logging.

https://gerrit.wikimedia.org/r/95985

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links