Last modified: 2014-06-09 06:18:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58935, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 56935 - MWDeprecationWarning: Use of "mwEditButtons" property is deprecated. Use mw.toolbar instead


Summary:	MWDeprecationWarning: Use of "mwEditButtons" property is deprecated. Use mw.t...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	LiquidThreads (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Low trivial (vote)
Target Milestone:	---
Assigned To:	Mateusz Maćkowski

URL:	http://www.google-melange.com/gci/tas...
Whiteboard:	gci2013
Keywords:	easy, javascript

Depends on:
Blocks:	code_quality
	Show dependency tree / graph

Reported:	2013-11-12 09:26 UTC by Helder
Modified:	2014-06-09 06:18 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2013-11-12 09:26:40 UTC

I'm getting the warning above from this file:
https://bits.wikimedia.org/static-1.23wmf3/extensions/LiquidThreads/lqt.js
when I click on any "Reply" buttons (with the classic edit toolbar enabled).

Comment 1 Bartosz Dziewoński 2013-12-23 19:27:53 UTC

That line should just be removed, mwEditButtons is no longer supported and any actions done to it are no-ops.

Comment 2 Nemo 2013-12-27 09:20:29 UTC

Ok for GCI.

Comment 3 Quim Gil 2013-12-29 06:01:53 UTC

Thank you! Google Code-in task created.

Comment 4 Gerrit Notification Bot 2013-12-29 13:48:03 UTC

Change 104346 had a related patch set uploaded by M4tx:
Remove use of deprecated mwEditButtons property

https://gerrit.wikimedia.org/r/104346

Comment 5 Gerrit Notification Bot 2013-12-29 18:54:48 UTC

Change 104346 merged by jenkins-bot:
Remove use of deprecated mwEditButtons property

https://gerrit.wikimedia.org/r/104346

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links