Last modified: 2013-11-26 19:49:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58901, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56901 - Port unusedfiles.py to Pywikibot core
Port unusedfiles.py to Pywikibot core
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Pywikipedia bugs
gci2013 https://www.mediawiki.org/wik...
: easy
Depends on:
Blocks: 55880
  Show dependency treegraph
 
Reported: 2013-11-11 11:55 UTC by Strainu
Modified: 2013-11-26 19:49 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Strainu 2013-11-11 11:55:41 UTC
PyWikibot [1] is a Python-based framework to write bots for MediaWiki. There are currently 2 versions of pywikibot currently used:
 - version 1.0 (also known as pywikibot-compat) is the legacy version
 - version 2.0 (also known as pywikibot-core) is a rewrite of the original framework, focusing solely on MediaWiki wikis with an API (version 1.14 or newer) and offering an improved internal architecture.

There are a number of scripts used by various robot operators that were used in pywikibot-compat but have not yet been adapted to work with pywikibot-core. One of those is unusedfiles.py, which Finds unused media using [[Special:Unusedimages]].

You can find information about how to convert the script on [2], [3]. Patches can be submited through the gerrit uploader [4] (you need a MediaWiki.org account). More documentation on gerrit can be found at [5].


[1] https://www.mediawiki.org/wiki/Manual:Pywikibot
[2] https://www.mediawiki.org/wiki/Manual:Pywikibot/2.0/Conversion
[3] https://www.mediawiki.org/wiki/Manual:Pywikibot/i18n_conversion
[4] https://tools.wmflabs.org/gerrit-patch-uploader/
[5] http://www.mediawiki.org/wiki/Manual:Pywikipediabot/Gerrit
Comment 1 Richard L 2013-11-20 22:39:09 UTC
I am a Google Code In Student who has accepted this Bug to conver unusedfiles.py from compat to core(https://google-melange.appspot.com/gci/task/view/google/gci2013/5799131951923200). Should I upload it to the original repository of pywikibot/compat, or to the pywikibot/core repository where it is ported to?
Comment 2 Strainu 2013-11-20 22:46:38 UTC
The file needs to get in pywikibot/core, so you need to generate a patch for that project.
Comment 3 Richard L 2013-11-20 22:59:17 UTC
Thanks fore the  response. Sorry, but i seem to have another problem, and I got the dump from the Gerrit uploader:

Result from uploading patch:
git clone --depth=1 ssh://gerrit/pywikibot/core /tmp/1609560.1.webgrid/tmp5VqLtG Cloning into '/tmp/1609560.1.webgrid/tmp5VqLtG'... Total 254 (delta 84), reused 94 (delta 52) git rev-parse --abbrev-ref HEAD Will commit to branch: master git config user.name [[mw:User:Richardusername]] git config user.email gerritpatchuploader@gmail.com scp -p gerrit:hooks/commit-msg .git/hooks/ git apply < patch fatal: unrecognized input patch -p0 < patch patch: **** Only garbage was found in the patch input. patch -p1 < patch patch: **** Only garbage was found in the patch input.
Upload failed
Reason: Patch failed (is your patch in unified diff format, and does it patch apply cleanly to master?) (check log above for details)

I read about using git diff in the Gerrit tutorial, should I use it instead?
Comment 4 Strainu 2013-11-20 23:16:10 UTC
How did you generate your patch? Normally, the procedure I suggest is the following:

- clone the pywikibot/core branch
- add the file, make the modifications etc.
- git add unusedfiles.py
- git commit (make sure you write a good commit description)
- git format-patch -1 HEAD

See http://stackoverflow.com/questions/6658313/generate-a-git-patch-for-a-specific-commit for details.

The git format-patch command will generate a patch file that you can then upload to gerrit.
Comment 5 Richard L 2013-11-23 17:04:34 UTC
https://gerrit.wikimedia.org/r/#/c/97016/
Comment 6 Gerrit Notification Bot 2013-11-23 20:32:30 UTC
Change 97016 had a related patch set uploaded by Richardll:
Ported unusedfiles.py from pywikibot compat to core

https://gerrit.wikimedia.org/r/97016
Comment 7 Gerrit Notification Bot 2013-11-23 21:54:36 UTC
Change 97016 merged by Strainu:
Ported unusedfiles.py to pywikibot/core, added unicode support.

https://gerrit.wikimedia.org/r/97016

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links