Last modified: 2014-01-22 15:24:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58856, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56856 - ResourceLoaderULSModule::getModifiedTime updates continuously
ResourceLoaderULSModule::getModifiedTime updates continuously
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Niklas Laxström
: performance
Depends on:
Blocks: uls-diet
  Show dependency tree / graph
 
Reported: 2013-11-10 10:11 UTC by Ori Livneh
Modified: 2014-01-22 15:24 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ori Livneh 2013-11-10 10:11:33 UTC 
ResourceLoaderULSModule updates its modified time whenever ResourceLoaderContext::getLanguage varies. ResourceLoaderContext::getLanguage varies gets the language via the 'lang' parameter on the module request. The lang parameter is set in mediawiki.js to wgUserLanguage.

Result: the version of ext.uls.languagenames is updated continuously as users with different language settings hit the site, with the effect that practically every request for the module (and any other module fetched in the same request) is uncached.

To confirm this bug report, you can go to enwiki and check mw.loader.getVersion('ext.uls.languagenames'); . Then reload and check again.

'mediawiki.language.data' appears to likewise update continuously.
Comment 1 Gerrit Notification Bot 2013-11-11 09:05:58 UTC 
Change 94708 had a related patch set uploaded by Nikerabbit:
ResourceLoaderULSModule::getModifiedTime updates continuously

https://gerrit.wikimedia.org/r/94708
Comment 2 Gerrit Notification Bot 2013-11-11 11:12:19 UTC 
Change 94708 merged by jenkins-bot:
ResourceLoaderULSModule::getModifiedTime updates continuously

https://gerrit.wikimedia.org/r/94708
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links