Last modified: 2014-04-04 19:35:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58835, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 56835 - VisualEditor: [Regression] Switch to wikitext feature gives an Edit conflict warning when editing from IP


Summary:	VisualEditor: [Regression] Switch to wikitext feature gives an Edit conflict ...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2014-04-10
Assigned To:	Alex Monk

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-09 10:09 UTC by Elitre
Modified:	2014-04-04 19:35 UTC (History)
CC List:	7 users (show)

See Also:	56767
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Elitre 2013-11-09 10:09:15 UTC

I thought it was Opera's fault,
but tested this again today and it's not related to the browser you're using.
It appears that when you edit as an unregistered user (on wikis which allow you to...) you'll always get an Edit conflict page when you try to save after you switched to wikitext.
Tested on multiple wikis on both ns0 and ns2.

Comment 1 Elitre 2013-11-11 21:34:23 UTC

(I wonder if https://bugzilla.wikimedia.org/show_bug.cgi?id=56849 is related?)

Comment 2 Gerrit Notification Bot 2013-11-18 05:57:22 UTC

Change 95730 had a related patch set uploaded by Catrope:
Share code between conflict resolution and the edit source switch

https://gerrit.wikimedia.org/r/95730

Comment 3 Gerrit Notification Bot 2013-11-26 10:42:17 UTC

Change 95730 merged by jenkins-bot:
Share code between conflict resolution and the edit source switch

https://gerrit.wikimedia.org/r/95730

Comment 4 Elitre 2014-01-07 23:16:27 UTC

Reported again on it.wp, I verified it on my sandbox there (http://it.wikipedia.org/wiki/Utente:Elitre_(WMF)/Sandbox_VE?veaction=edit); I got the warning, then tried to save anyway, I apparently managed to but nothing appears in the history.

Comment 5 Alex Monk 2014-03-27 23:35:11 UTC

I suspect this might have something to do with this code in ve.init.mw.Target.js:

>'wpStarttime': this.baseTimeStamp,
>'wpEdittime': this.startTimeStamp,

Which seems a bit backwards to me...

Comment 6 Alex Monk 2014-03-28 18:38:42 UTC

So I think that:
* A conflict is always detected when having switched from VE
* Said conflict is suppressed when Revision::userWasLastToEdit is run for a logged in user, but if they're anonymous then it's not suppressed.

Comment 7 Alex Monk 2014-04-03 22:06:30 UTC

Some of my confusion on this bug was caused by some extra ways MediaWiki can resolve edit conflicts which I hadn't properly taken into account when testing. It looks like swapping those values fixes this bug. Assigning this to me and bumping the milestone forward.

Comment 8 Gerrit Notification Bot 2014-04-03 22:09:40 UTC

Change 123795 had a related patch set uploaded by Alex Monk:
Fix order of start and base timestamps when switching to the wikitext editor

https://gerrit.wikimedia.org/r/123795

Comment 9 Gerrit Notification Bot 2014-04-04 19:32:00 UTC

Change 123795 merged by jenkins-bot:
Fix order of start and base timestamps when switching to the wikitext editor

https://gerrit.wikimedia.org/r/123795

Comment 10 Alex Monk 2014-04-04 19:35:24 UTC

I think this is fixed now. If you notice any issues with it (easiest way to test right now is on beta) please reopen

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links