Last modified: 2014-04-15 22:37:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58786, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56786 - Remove "Printable version" link in toolbox from [[Special:Upload]]
Remove "Printable version" link in toolbox from [[Special:Upload]]
Status: UNCONFIRMED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.23.0
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-08 17:36 UTC by Eduard Braun
Modified: 2014-04-15 22:37 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Eduard Braun 2013-11-08 17:36:43 UTC
A recent change (maybe [1]?) added a "Printable version" link to the toolbox on [[Special:Upload]].

Despite the fact, that is not useful at all there, it breaks the access key ("p") for the preview button which is added by custom JS to Special:Upload on many Wikis (e.g. [2],[3]).

The easiest option would probably be to not display the link there, similarly as it is not shown when editing an article.


[1] https://gerrit.wikimedia.org/r/#/c/62844/
[2] https://commons.wikimedia.org/wiki/MediaWiki:UploadForm.js
[3] https://de.wikipedia.org/wiki/MediaWiki:Onlyifuploading.js
Comment 1 MZMcBride 2013-11-10 21:15:40 UTC
Using "P" for preview and print is always inevitably going to result in collisions, isn't it? I think it makes sense to focus on handling collisions gracefully rather than trying to special-case Special:Upload.
Comment 2 Gadget850 2013-12-03 19:43:31 UTC
I don't see Print/Export in the sidebar with 1.23wmf4 on enwiki.
Comment 3 MZMcBride 2013-12-03 19:53:39 UTC
(In reply to comment #2)
> I don't see Print/Export in the sidebar with 1.23wmf4 on enwiki.

I don't know what this comment means.

This bug is about a "Printable version" link in the sidebar at [[Special:Upload]]. I see this link on both the German and English Wikipedias currently (in the "Tools" sidebar section).
Comment 4 Bawolff (Brian Wolff) 2013-12-03 21:54:47 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > I don't see Print/Export in the sidebar with 1.23wmf4 on enwiki.
> 
> I don't know what this comment means.
> 
> This bug is about a "Printable version" link in the sidebar at
> [[Special:Upload]]. I see this link on both the German and English Wikipedias
> currently (in the "Tools" sidebar section).

I think he meant the collection/pdf download stuff, which has a similar name but is separate from what this bug is about.
Comment 5 Bartosz Dziewoński 2014-04-15 22:37:54 UTC
I think this should be handled by your custom script.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links