Last modified: 2013-11-08 19:30:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56779 - VisualEditor: The direction of the <textarea> in extension tags editor must correspond to the surrounding content direction
VisualEditor: The direction of the <textarea> in extension tags editor must c...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-11-14
Assigned To: Moriel Schottlender
:
Depends on:
Blocks: ve-rtl
  Show dependency treegraph
 
Reported: 2013-11-08 14:14 UTC by Amir E. Aharoni
Modified: 2013-11-08 19:30 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2013-11-08 14:14:42 UTC
Currently, if I go to https://www.mediawiki.org/wiki/User:Amire80/ve-poem and edit it using VE, I can edit the content of the <poem> tag. If my UI language is Hebrew, then the <textarea> for editing the poem is RTL. I would expect it to be LTR.

Ideally the default direction for the <textarea> that this feature should be the direction of the surrounding text. If it's hard to get, then the direction of the page's content will probably suffice. (Currently it will be the same as the content language of the wiki, but it may change some day when we finally introduce page language.)

There can also be some tags for which the default direction must be different, such as <source>, but that's an issue for a separate bug.
Comment 1 Amir E. Aharoni 2013-11-08 14:23:04 UTC
From IRC:

<mooeypoo>	what do you mean "must correspond to surrounding content direction?
<mooeypoo>	of the <poem> ?
<mooeypoo>	so, it should be content direction rather than GUI direction?
<aharoni>	mooeypoo: It definitely shouldn't be the GUI direction. It has nothing to do with it.
<mooeypoo>	nods
<aharoni>	The direction of the inspector's GUI should be the GUI direction,
<aharoni>	but the textarea needs the direction of the content.
<mooeypoo>	yeah
<mooeypoo>	makes sense, just wanted to make sure
<aharoni>	Ideally, if the wiki is in English, but it's a <poem> tag inside <div lang="fa" dir="rtl">, then the textarea should be rtl.
Comment 2 Amir E. Aharoni 2013-11-08 14:28:00 UTC
Related: Bug 56780.
Comment 3 Gerrit Notification Bot 2013-11-08 15:56:14 UTC
Change 94375 had a related patch set uploaded by Mooeypoo:
MWExtensionInspector input direction based on content

https://gerrit.wikimedia.org/r/94375
Comment 4 Gerrit Notification Bot 2013-11-08 19:30:00 UTC
Change 94375 merged by jenkins-bot:
MWExtensionInspector input direction based on content

https://gerrit.wikimedia.org/r/94375

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links