Last modified: 2014-11-19 02:57:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58659, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56659 - VisualEditor: Use mw.Api library in mw.Target instead of our own functions
VisualEditor: Use mw.Api library in mw.Target instead of our own functions
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks: 73593
  Show dependency tree / graph
 
Reported: 2013-11-06 07:51 UTC by Roan Kattouw
Modified: 2014-11-19 02:57 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-11-06 07:51:33 UTC 
mw.Api has nice features now like automatically retrying bad tokens, we should migrate to it.
Comment 1 James Forrester 2013-11-06 16:22:22 UTC 
One of the intentional functionality points in current VE is warning users when the token is bad because they user has changed (i.e. you've been logged out, or logged in as someone else), and explicitly asking for the user to consent to continue.

This avoids the repeated cause of pain for users of the current wikitext editor where if you get logged out for some reason, it just saves as your IP, outing you (and needing revision deletion, drama and anguish). We should be fixing the wikitext editor to mirror the protocol in VisualEditor.

It's unclear from how this is written whether "automatically retrying" means getting a new one, but only for a given user, or getting a new one regardless. If the latter, I think this is a WONTFIX. Advice?
Comment 2 Roan Kattouw 2013-11-06 18:32:33 UTC 
Yeah, you're right, the automatic retry without regard for the user changing is not what we want.
Comment 3 James Forrester 2014-11-13 14:58:13 UTC 
Done in https://gerrit.wikimedia.org/r/#/c/98713/ AFAICT.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links