Last modified: 2013-11-22 23:18:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58179, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56179 - Architecture review of GWToolset
Architecture review of GWToolset
Product: MediaWiki extensions
Classification: Unclassified
GWToolset (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Aaron Schulz
Depends on: 56186
Blocks: 56181 56182
  Show dependency treegraph
Reported: 2013-10-25 18:45 UTC by Greg Grossmeier
Modified: 2013-11-22 23:18 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Greg Grossmeier 2013-10-25 18:45:04 UTC
Please do architecture review of GWToolset
Comment 2 Bryan Davis 2013-10-25 19:16:21 UTC
At minimum I would like Aaron to take a look at the usage of UploadStash and the Job classes.
Comment 3 dan 2013-11-06 08:38:45 UTC
* initial review date scheduled for friday, 2013-11-01
** aaron had to cancel since he was not feeling well.
** gergő tisza recommended separating exceptions representing user errors into a subclass, let other exceptions fall through to top level
** aaron to add required mvp changes to the meeting etherpad
** bryan davis to facilitate set-up of a new meeting with aaron if necessary
** dan to flush out the high level design concept
Comment 4 dan 2013-11-06 08:39:25 UTC
* addresses gergő tisza recommendation
Comment 5 dan 2013-11-06 08:45:30 UTC
* during the review of
  * gergő mentioned a concern with the special page ajax handler using exit()
  * both bryan and gergő mentioned a concern about the need to swallow
    E_USER_NOTICE errors
  * dan to investigate using the api instead of the special page to handler ajax
    requests for the js save metadata mapping call.
Comment 6 dan 2013-11-06 14:11:11 UTC
* created an initial design page
Comment 7 dan 2013-11-07 23:38:17 UTC
* re-factored save metadata mapping to address bryan and gergő’s concerns about
  the special page AjaxHandler


* 2013-07, aaron mentioned a concern about the potential file size of metadata
  files. he wants us to use the chunked uploads instead of uploading directly 
  to the stash. he sees this as a blocker for phase 1 deploy.

  * working on a solution
Comment 8 dan 2013-11-22 05:27:20 UTC
after investigating/implementing the use of chunked uploads,  i found that the api, would not allow us to upload .xml files. there may be another path that would allow us to do so, but after an irc chat with aaron and chris, they came up with idea to use a “secured/private” filebackend instead. aaron also recommended adding the possibility to download the metadata file from another domain rather than upload it from a local computer.
Comment 9 dan 2013-11-22 05:28:56 UTC
- filebackend:
Comment 11 Aaron Schulz 2013-11-22 23:18:05 UTC
Closing this, as this has moved on to security review.

Note You need to log in before you can comment on or make changes to this bug.