Last modified: 2014-01-21 01:58:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58143, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56143 - License Info for Media Viewer
License Info for Media Viewer
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Tisza Gergő
:
: 56587 (view as bug list)
Depends on: 56598
Blocks: 56140
  Show dependency treegraph
 
Reported: 2013-10-25 00:44 UTC by Fabrice Florin
Modified: 2014-01-21 01:58 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Media-Viewer-Lightbox-View-Screenshot-Alpha-10-24-2013.png (630.22 KB, image/png)
2013-10-25 00:44 UTC, Fabrice Florin
Details

Description Fabrice Florin 2013-10-25 00:44:25 UTC
Created attachment 13574 [details]
Media-Viewer-Lightbox-View-Screenshot-Alpha-10-24-2013.png

If a file is licensed under a Creative Commons license, we want the Media Viewer to display its 'CC' label (e.g. 'CC-BY-SA-3.0'), as described in our Mingle feature requirement (1).

But this doesn't seem to be working as intended on our multimedia alpha prototype (2). For example, the aquarium photo in the attached screenshot (3) is licensed under 'CC-BY-SA-3.0' (hidden category), but that label is not displayed on the alpha prototype. 

Instead, it just says 'Licensing Info'. Even if it were not CC, the recommended copy for generic links is 'See license info', as requested on Mingle.

More info about Media Viewer on our project page (3).

(1) https://mingle.corp.wikimedia.org/projects/multimedia/cards/34

(2) https://commons.wikimedia.org/wiki/File:Media-Viewer-Lightbox-View-Screenshot-Alpha-10-24-2013.png

(3) https://commons.wikimedia.org/wiki/File:Wikimedia_Foundation_2013_All_Hands_Offsite_-_Day_2_-_Photo_24.jpg

(4) https://upload.wikimedia.org/wikipedia/commons/f/fe/MediaViewer_Sept9.png

(5) https://www.mediawiki.org/wiki/Multimedia/Media_Viewer
Comment 1 Mark Holmquist 2013-10-25 23:11:07 UTC
Actually a bug in CommonsMetadata - it's returning "LicenseUrl" instead of "License" on Commons images. We either need to translate LicenseUrls into licenses, or use the existing solution we have based on categories...maybe CommonsMetadata can't see hidden categories on a remote site? Investigate.

Assigning Gergo.
Comment 2 Tisza Gergő 2013-10-28 07:36:59 UTC
CommonsMetadata is intended to run on the central repository, but in our test setup it actually runs on the frontend wiki. It still kind of works, but some things are not accessible for a remote file, and remote categories are one of them. So License (which is based on categories) is not set, only LicenseUrl (which is based on the description page).
Comment 3 Mark Holmquist 2013-10-28 23:27:19 UTC
So wait.

Will this work once the central repo has CMD on it? Should I try to handle LicenseUrl too?
Comment 4 Mark Holmquist 2013-10-28 23:41:02 UTC
OK, we now fall back to the file page in _all_ cases. Try the new patch out for size. I'll close this bug since it never actually hit master.

https://gerrit.wikimedia.org/r/90267
Comment 5 Fabrice Florin 2013-11-01 03:06:25 UTC
Reopening this bug, because it is still happening on beta for all the photos I uploaded and featured on this page (Hong Kong, Aquarium, Kerala beach, Wikimedia team):

http://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo

All these photos should display a 'CC-BY-SA-3.0' label in light box view, but are saying 'License info' instead.
Comment 6 Tisza Gergő 2013-11-04 20:35:48 UTC
Unfortunately beta sites use the real Commons, not Commons beta.
So this is more of a bug in our test setup than in MediaViewer/CommonsMetadata.
Comment 7 Fabrice Florin 2013-11-04 23:07:42 UTC
I can reproduce this problem on MediaWiki.org as well, which I don't believe is Beta.

None of the CC images I posted on this MW.org are showing the correct CC-BY-SA label: (aquarium, nautilus, Kerala beach) 

https://www.mediawiki.org/wiki/Lightbox_demo

To be clear, I and other user expect the 'Licensing information' label to be replaced by 'CC-BY-SA-3.0' or whatever license we put in when we uploaded a file, as specified here:

https://mingle.corp.wikimedia.org/projects/multimedia/cards/34

This is an important request, which is going to be echoed over and over again by other users until we fulfill it.
Comment 8 Tisza Gergő 2013-11-05 01:01:58 UTC
Apparently Commons is a ForeignDBViaLBRepo, not a ForeignAPIRepo, and CommonsMetadata cannot handle that. This will be complicated...
Comment 9 Tisza Gergő 2013-11-05 01:11:58 UTC
*** Bug 56587 has been marked as a duplicate of this bug. ***
Comment 10 Gerrit Notification Bot 2013-11-05 23:36:50 UTC
Change 93889 had a related patch set uploaded by Gergő Tisza:
Use description HTML structure instead of categories to identify license

https://gerrit.wikimedia.org/r/93889
Comment 11 Gerrit Notification Bot 2013-11-06 18:46:40 UTC
Change 93889 merged by jenkins-bot:
Use description HTML structure instead of categories to identify license

https://gerrit.wikimedia.org/r/93889
Comment 12 Tisza Gergő 2013-11-06 19:48:13 UTC
This mostly works now; closing it in favor of more specific bugs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links