Last modified: 2014-02-21 11:11:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58090, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56090 - Do not change targets to javascript:void(0); on JavaScript load for various "edit" links
Do not change targets to javascript:void(0); on JavaScript load for various "...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Wikidata bugs
: javascript
Depends on: 54098
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-24 10:35 UTC by Liangent
Modified: 2014-02-21 11:11 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2013-10-24 10:35:41 UTC
Instead, call event.preventDefault() on their onclick event.

Otherwise, with JavaScript loaded, midclicking the link (= open a new tab) creates a new empty page at javascript:void(0);.
Comment 1 Yair Rand 2014-02-12 06:08:52 UTC
As far as I can tell, the targets aren't actually changed. Instead, every single edit link on the page is actually removed/deleted. ($( 'td.wb-editsection' ).empty(); $( 'span.wb-editsection, div.wb-editsection' ).remove(); in wikibase.ui.entityViewInit.js) New ones, frequently hundreds of them, are built from scratch later on, with the target as javascript:void(0). That's probably awful for performance.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links