Last modified: 2014-04-20 16:21:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58035, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56035 - It's unclear what the default values for RecentChangesPageGenerators arguments do
It's unclear what the default values for RecentChangesPageGenerators argument...
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
core-(2.0)
All All
: Normal normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks: 56190
  Show dependency tree / graph
 
Reported: 2013-10-23 08:13 UTC by Wieland Hoffmann
Modified: 2014-04-20 16:21 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Wieland Hoffmann 2013-10-23 08:13:52 UTC 
RecentChangesPageGenerator takes a few arguments like showMinor, showAnon, ... that are supposed to be boolean. However, they all have a default value of None, but the documentation only covers the case where they're either True or False. (The same is true for the recentchanges method in site.py that the generator uses.)
Comment 1 Kunal Mehta (Legoktm) 2013-10-23 15:36:12 UTC 
In this case if the parameter is None, it doesn't specify a preference, so it uses the API default, which can be seen at [[mw:API:Recentchanges]]
Comment 2 Wieland Hoffmann 2013-10-23 16:24:19 UTC 
That page doesn't tell me if '!minor' or 'minor' is the default either.
Comment 3 Wieland Hoffmann 2013-10-23 16:29:47 UTC 
Ah, sorry, that page does actually make it more clear that the default is 'just list all edits'.
Comment 4 Merlijn van Deen (test) 2013-10-23 16:32:28 UTC 
Hrm. Then we still have an issue, as showMinor=True does not imply *only* minor edits are shown, which is what passing 'minor' to the API means.
Comment 5 Mpaa 2014-01-07 21:41:24 UTC 
showMinor=True shows *only* minor edits. Docstring looks OK to me:
   @param showMinor: if True, only list minor edits; if False (and not None), only list non-minor edits

To be really picky, it should be specified that None shows all ...
Anyhow, I added to Pagegenerators additional args present in site.recentchanges() and updated doc string.
Comment 6 Gerrit Notification Bot 2014-01-07 21:55:48 UTC 
Change 106122 had a related patch set uploaded by Mpaa:
(bug 56035) RecentChangesPageGenerators arguments do

https://gerrit.wikimedia.org/r/106122
Comment 7 Gerrit Notification Bot 2014-04-20 13:35:05 UTC 
Change 106122 merged by jenkins-bot:
(bug 56035) RecentChangesPageGenerators arguments do

https://gerrit.wikimedia.org/r/106122
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links