Last modified: 2013-11-12 10:41:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57912, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55912 - Language#formatExpiry needs database connection
Language#formatExpiry needs database connection
Status: NEW
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2013-10-19 12:33 UTC by Bartosz Dziewoński
Modified: 2013-11-12 10:41 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2013-10-19 12:33:53 UTC 
Language#formatExpiry needs database connection (to get the value of infinity string – `$infinity = wfGetDB( DB_SLAVE )->getInfinity();`). It should not.

After this is fixed, the FIXME added in https://gerrit.wikimedia.org/r/#/c/80663/ should be removed.
Comment 1 Siebrand Mazeland 2013-10-19 15:15:09 UTC 
Why is this classified as an i18n issue? AFAICT getInfinity() was implemented in the Database class for some reason.

includes/db/Database.php, Class Database, ~line 3800:

/**
 * Find out when 'infinity' is. Most DBMSes support this. This is a special
 * keyword for timestamps in PostgreSQL, and works with CHAR(14) as well
 * because "i" sorts after all numbers.
 *
 * @return String
 */
public function getInfinity() {
	return 'infinity';
}
Comment 2 Bartosz Dziewoński 2013-10-19 15:17:00 UTC 
Feel free to change the component if you think it's incorrect, I18n felt appropriate as this is an issue with (among others) the Language class.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links