Last modified: 2014-06-12 04:54:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57839, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55839 - VisualEditor: Link inspector does not show suggestions dropdown on open if link target is the same as the target of the most recently inspected link
VisualEditor: Link inspector does not show suggestions dropdown on open if li...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-06-12
Assigned To: Trevor Parscal
:
Depends on:
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2013-10-17 14:11 UTC by Roan Kattouw
Modified: 2014-06-12 04:54 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Showing suggestions in blank space (39.17 KB, image/png)
2013-11-01 23:46 UTC, Rummana Yasmeen
Details
Showing suggestions in blank space (15.00 KB, image/png)
2013-11-01 23:49 UTC, Rummana Yasmeen
Details
showing wrong suggestions at the end of the previously selected link (16.73 KB, image/png)
2013-11-01 23:50 UTC, Rummana Yasmeen
Details

Description Roan Kattouw 2013-10-17 14:11:36 UTC
1. Create a page with two links that point to the same page or URL, and a link that points to a different page/URL
2. Inspect one of the twin links with the link inspector. The suggestions dropdown is displayed (*)
3. Inspect the other twin link. The suggestions dropdown isn't displayed
4. Inspect the third link. The suggestions dropdown is displayed again
5. Inspect the link from #3. The suggestions dropdown is displayed now
6. Close the inspector, the inspect the same link again. The suggestions dropdown isn't displayed

This is because the value in the text input doesn't change when you inspect the same link twice or inspect two links with the same target. The link inspector should consistently display the dropdown when it opens.

(*) I would argue that we should /not/ display the dropdown in this case, IMO it's useless and confusing. But the point of this bug is that we should have consistent behavior.
Comment 1 Rummana Yasmeen 2013-11-01 22:59:39 UTC
Another issue which might be related with this follows the following steps:

1.Create any link with a target URL
2.Inspect another link of the page with a different target URL
3.Now point to a blank space and press ctrl+k or command+k

Observed Result:

The link inspector appears in a swipe way from right to left and the content of the link inspector is the suggestion of the link that was created in step 1.

I am not sure how the expected result should be in this case when a user press command+k in an empty space.I think there should not be any pre-set suggestion for that.
Comment 2 Rummana Yasmeen 2013-11-01 23:44:40 UTC
In step 3, if i click on the link icon from the tool bar instead of pressing ctrl+k or command+k , then the link inspector opens up at the end of the text created in step 1.

See the screenshots for more reference.
Comment 3 Rummana Yasmeen 2013-11-01 23:46:04 UTC
Created attachment 13668 [details]
Showing suggestions in blank space
Comment 4 Rummana Yasmeen 2013-11-01 23:49:42 UTC
Created attachment 13669 [details]
Showing suggestions in blank space
Comment 5 Rummana Yasmeen 2013-11-01 23:50:35 UTC
Created attachment 13670 [details]
showing wrong suggestions at the end of the previously selected link
Comment 6 James Forrester 2014-06-12 04:54:03 UTC
This is now fixed, but anyway masked by the expedient of not opening the suggestion box until the user changes something.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links