Last modified: 2013-10-15 23:38:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57720, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55720 - OAuth MediaWiki extension's app grant management form's "Allowed on wiki" input needs stricter input validation
OAuth MediaWiki extension's app grant management form's "Allowed on wiki" inp...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OAuth (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: 55679
  Show dependency tree / graph
 
Reported: 2013-10-14 22:20 UTC by MZMcBride
Modified: 2013-10-15 23:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2013-10-14 22:20:26 UTC 
If I go to [[testwiki:Special:MWOAuthManageMyGrants/manage/72]] and enter "mediawiki" for the "Allowed on wiki" text input and press the "update grants" button, the form will accept the input.

If I return to [[testwiki:Special:MWOAuthManageMyGrants/proposed]], I see:

---
Allowed on wiki: media.wikipedia.org
---

Eep!

This is related to bug 55714 and 55703.
Comment 1 MZMcBride 2013-10-14 22:26:19 UTC 
If I enter "<b>wiki" for the "Allowed on wiki" field, the form successfully saves/submits, but then I get "Allowed on wiki: <b>.wikipedia.org" at [[testwiki:Special:MWOAuthManageMyGrants/proposed]].
Comment 2 Aaron Schulz 2013-10-15 16:42:36 UTC 
This was already fixed in master
Comment 3 MZMcBride 2013-10-15 23:23:20 UTC 
(In reply to comment #2)
> This was already fixed in master

https://gerrit.wikimedia.org/r/89236

Thank you for fixing this. Please provide a reference when closing out bugs like this.
Comment 4 Aaron Schulz 2013-10-15 23:29:18 UTC 
No it was https://gerrit.wikimedia.org/r/#/c/89101/
Comment 5 MZMcBride 2013-10-15 23:38:28 UTC 
Bah, thanks. :-)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links