Last modified: 2013-11-03 19:34:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57684, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55684 - Cite: Module "ext.cite" should not be loaded on pages without <ref> (e.g. Special pages)
Cite: Module "ext.cite" should not be loaded on pages without <ref> (e.g. Spe...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Cite (Other open bugs)
unspecified
All All
: High normal (vote)
: MW 1.23 version
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: 55683
  Show dependency treegraph
 
Reported: 2013-10-14 03:28 UTC by MZMcBride
Modified: 2013-11-03 19:34 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-10-14 03:28:34 UTC
According to mw.loader.inspect(), [[Special:BlankPage]] loads the "ext.cite" ResourceLoader module. This seems to be a global module, but it doesn't need to be loaded on any Special page besides Special:Cite, I imagine.

I'm not sure if this is a bug. And if it is a bug, I'm not sure if it should be filed against the "Cite" MediaWiki extension or against MediaWiki core JavaScript.
Comment 1 Kunal Mehta (Legoktm) 2013-10-14 03:41:36 UTC
(In reply to comment #0)

> I'm not sure if this is a bug. And if it is a bug, I'm not sure if it should
> be
> filed against the "Cite" MediaWiki extension or against MediaWiki core
> JavaScript.

According to the source code (https://github.com/wikimedia/mediawiki-extensions-Cite/blob/master/Cite.php#L72), it's added by the extension.
Comment 2 Kunal Mehta (Legoktm) 2013-10-14 03:47:52 UTC
(In reply to comment #0)
> According to mw.loader.inspect(), [[Special:BlankPage]] loads the "ext.cite"
> ResourceLoader module. This seems to be a global module, but it doesn't need
> to
> be loaded on any Special page besides Special:Cite, I imagine.

Technically any Special page might have <ref></ref> tags due to local modifications of system messages, so in those cases the RL module would be needed.
Comment 3 Krinkle 2013-10-14 04:22:25 UTC
(In reply to comment #2)
> (In reply to comment #0)
> > According to mw.loader.inspect(), [[Special:BlankPage]] loads the "ext.cite"
> > ResourceLoader module. This seems to be a global module, but it doesn't need
> > to
> > be loaded on any Special page besides Special:Cite, I imagine.
> 
> Technically any Special page might have <ref></ref> tags due to local
> modifications of system messages, so in those cases the RL module would be
> needed.

In that case the parser hook can call $parserOutput->addModules(). The Cite extension is still using the classic way of adding resources through wgHooks['BeforePageDisplay'] instead of doing it the new way through contextual addModules when it actually needs to.
Comment 4 Gerrit Notification Bot 2013-10-14 04:32:43 UTC
Change 89617 had a related patch set uploaded by Legoktm:
Only load RL modules when a <ref> tag is being used

https://gerrit.wikimedia.org/r/89617
Comment 5 Gerrit Notification Bot 2013-11-03 18:32:18 UTC
Change 89617 merged by jenkins-bot:
Only load RL modules when a <ref> tag is being used

https://gerrit.wikimedia.org/r/89617

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links