Last modified: 2013-10-29 20:32:14 UTC
The commit If79d2d1f72579627597b291eec759441d6763c34 "Turn screen.css into screen.less" didn't account for the installer and needs to be fixed.
Could you elaborate on what you mean by "the installer" and what it didn't account for? I am unfamiliar with the installer and what needs to be fixed. Does it reference screen.css as the css file output has not changed in any significant way...
Ok, so it seems the file includes/installer/WebInstallerOutput.php references screen.css - this is bad as they are two distinctly separate things. The getCSS function should probably return the styles property of the module it belongs too and there should be a test added to ensure this works as expected and this doesn't break in future. If this can't use RL it will also need to access and run the LESS compiler Is there any reason this file doesn't use ResourceLoader (I assume this code predates it)?
load.php is not yet available because there is not LocalSettings.php yet.
instead of fixing the less/css problem, it may only be necessary to duplicate the styles into skins/common/config.css
(In reply to comment #4) > instead of fixing the less/css problem, it may only be necessary to duplicate > the styles into skins/common/config.css I think that would be sufficient for the 1.22 release, at least.
Change 89610 had a related patch set uploaded by PleaseStand: Installer: Run the LESS compiler for screen.less https://gerrit.wikimedia.org/r/89610
*** Bug 55954 has been marked as a duplicate of this bug. ***
Haven't tried, but I assume that an unstyled interface does not entirely block continuing with the installation, hence reverting severity=blocker.
Change 89610 merged by MarkAHershberger: installer: Run the LESS compiler for *.less files https://gerrit.wikimedia.org/r/89610
Change 92459 had a related patch set uploaded by MarkAHershberger: installer: Run the LESS compiler for *.less files https://gerrit.wikimedia.org/r/92459
Change 92459 abandoned by MarkAHershberger: installer: Run the LESS compiler for *.less files Reason: one day I'll understand gerrit https://gerrit.wikimedia.org/r/92459
Change 92462 had a related patch set uploaded by MarkAHershberger: installer: Run the LESS compiler for *.less files https://gerrit.wikimedia.org/r/92462
Change 92464 had a related patch set uploaded by MarkAHershberger: installer: Run the LESS compiler for *.less files https://gerrit.wikimedia.org/r/92464
Change 92462 merged by MarkAHershberger: installer: Run the LESS compiler for *.less files https://gerrit.wikimedia.org/r/92462
Change 92464 abandoned by MarkAHershberger: installer: Run the LESS compiler for *.less files https://gerrit.wikimedia.org/r/92464
Change 92475 had a related patch set uploaded by MarkAHershberger: installer: Run the LESS compiler for *.less files https://gerrit.wikimedia.org/r/92475
Change 92475 merged by jenkins-bot: installer: Run the LESS compiler for *.less files https://gerrit.wikimedia.org/r/92475
