Last modified: 2014-04-17 22:50:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57543, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55543 - Upload test for file with no extension failing under hhvm: FILETYPE_BADTYPE instead of FILETYPE_MISSING.
Upload test for file with no extension failing under hhvm: FILETYPE_BADTYPE i...
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-10 01:45 UTC by Chad H.
Modified: 2014-04-17 22:50 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chad H. 2013-10-10 01:45:07 UTC
We're getting FILETYPE_BADTYPE when we should be getting FILETYPE_MISSING.

$ hhvm phpunit.php includes/upload/UploadBaseTest.php
PHPUnit 3.7.23 by Sebastian Bergmann.

Configuration read from /www/mediawiki/core/tests/phpunit/suite.xml

.....F......

Time: 194 ms, Memory: 11.67Mb

There was 1 failure:

1) UploadBaseTest::testTitleValidation with data set #5 ('A', NULL, 8, 'upload title without extension')
upload title without extension code
Failed asserting that 9 matches expected 8.

/www/mediawiki/core/tests/phpunit/includes/upload/UploadBaseTest.php:38
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64
Comment 1 Andre Klapper 2014-01-10 00:38:45 UTC
[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]
Comment 2 Aaron Schulz 2014-04-17 22:50:49 UTC
Works with hhvm 3.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links