Last modified: 2014-04-10 04:02:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57532, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55532 - BitmapMetadataHandlerTest::testIPTCDatesInvalid() failing under hhvm
BitmapMetadataHandlerTest::testIPTCDatesInvalid() failing under hhvm
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm, upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-09 22:38 UTC by Chad H.
Modified: 2014-04-10 04:02 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chad H. 2013-10-09 22:38:06 UTC
There was 1 failure:

1) BitmapMetadataHandlerTest::testIPTCDatesInvalid
Failed asserting that true is false.

/www/mediawiki/core/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php:87
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64
Comment 1 Chad H. 2013-10-10 01:02:20 UTC
I'm pretty sure this be an +upstream bug, but the ext/exif code is kind of hard to follow :)
Comment 2 Ori Livneh 2014-01-08 06:36:35 UTC
This is indeed an upstream bug:

    $ php -v
    PHP 5.3.10-1ubuntu3.9+wmf1 with Suhosin-Patch (cli) (built: Dec 13 2013 17:12:38) 
    Copyright (c) 1997-2012 The PHP Group
    Zend Engine v2.3.0, Copyright (c) 1998-2012 Zend Technologies
        with Xdebug v2.1.0, Copyright (c) 2002-2010, by Derick Rethans
    $ hhvm --version
    HipHop VM v2.3.2 (rel)
    Compiler: heads/HHVM-2.3-0-g3fa32fab6e2373a26a5ba6167b750eeaaf0052c2
    Repo schema: e163dcc55f565103c06bfcdb714b619a58ba4e3a
    $ php -r "var_dump( date_create( '19420713250502' ) );"
    bool(false)
    $ hhvm --php -r "var_dump( date_create( '19420713250502' ) );"
    object(DateTime)#1 (0) {
    }
    $ php -r "var_dump( new DateTime( '19420713250502' ) );"
    PHP Fatal error:  Uncaught exception 'Exception' with message 'DateTime::__construct(): Failed to parse time string (19420713250502) at position 12 (0): Unexpected character' in Command line code:1
    Stack trace:
    #0 Command line code(1): DateTime->__construct('19420713250502')
    #1 {main}
      thrown in Command line code on line 1

    Fatal error: Uncaught exception 'Exception' with message 'DateTime::__construct(): Failed to parse time string (19420713250502) at position 12 (0): Unexpected character' in Command line code on line 1

    Exception: DateTime::__construct(): Failed to parse time string (19420713250502) at position 12 (0): Unexpected character in Command line code on line 1

    Call Stack:
        0.0001     626480   1. {main}() Command line code:0
        0.0001     627336   2. DateTime->__construct() Command line code:1

    $ hhvm --php -r "var_dump( new DateTime( '19420713250502' ) );"
    object(DateTime)#1 (0) {
    }

It appears to have been fixed three weeks ago, in <https://github.com/facebook/hhvm/commit/9d80cda2cd96f36d506cb0b6bc0675a650265c2f>. The patch did not make it into HHVM 2.3.2 but should be part of the next release.
Comment 3 Andre Klapper 2014-01-10 00:38:30 UTC
[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]
Comment 4 Aaron Schulz 2014-04-09 21:20:35 UTC
Can this be closed now?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links