Last modified: 2013-10-30 16:20:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57476, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 55476 - MultimediaViewer lightbox appears at top of document instead of viewport


Summary:	MultimediaViewer lightbox appears at top of document instead of viewport

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	MultimediaViewer (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Mark Holmquist

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	56140
	Show dependency tree / graph

Reported:	2013-10-08 18:33 UTC by Brion Vibber
Modified:	2013-10-30 16:20 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2013-10-08 18:33:47 UTC

(Jotting down some issues noted while testing, things that aren't directly related to the commits.)


If you're scrolled down somewhere on a page, the viewer lightbox pops up waaay up at the top of the document, and you have to go scrolling up to find your image and the close box.

The lightbox should be positioned to the viewport (probably use CSS position:fixed) so no scrolling is needed.

Comment 1 Mark Holmquist 2013-10-27 19:47:09 UTC

Technically an upstream bug in multilightbox - I'll tell that lazy maintainer (spoiler alert: it's me) to fix his shit.

Comment 2 Mark Holmquist 2013-10-28 18:30:32 UTC

Bit anticlimactic but still.

Taking, will work on it now.

Comment 3 Gerrit Notification Bot 2013-10-28 18:40:27 UTC

Change 92353 had a related patch set uploaded by MarkTraceur:
position: fixed for multilightbox

https://gerrit.wikimedia.org/r/92353

Comment 4 Mark Holmquist 2013-10-28 18:46:23 UTC

Looks fixed to me, in the patch.

Comment 5 Fabrice Florin 2013-10-29 18:07:27 UTC

Thanks for this good suggestion, Brion. Makes good sense to me, and this is definitely high priority for the first release. :)

Comment 6 Gerrit Notification Bot 2013-10-30 16:18:22 UTC

Change 92353 merged by jenkins-bot:
position: fixed for multilightbox

https://gerrit.wikimedia.org/r/92353

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links