Last modified: 2014-10-21 16:32:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57435, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55435 - AbuseFilter: PHP Catchable fatal error: Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given, called in AbuseFilter.class.php on
AbuseFilter: PHP Catchable fatal error: Argument 1 passed to RequestContext:...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-07 18:30 UTC by Sam Reed (reedy)
Modified: 2014-10-21 16:32 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2013-10-07 18:30:10 UTC
PHP Catchable fatal error:  Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.class.php on line 901 and defined in /usr/local/apache/common-local/php-1.22wmf20/includes/context/RequestContext.php on line 93
Comment 1 Sam Reed (reedy) 2013-10-07 18:32:02 UTC
[07-Oct-2013 18:28:17] Catchable fatal error: Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.class.php on line 901 and defined at /usr/local/apache/common-local/php-1.22wmf20/includes/context/RequestContext.php on line 93
Server: mw1219
Method: GET
URL: http://en.wikibooks.org/wiki/Special:CentralAutoLogin/start?type=1x1&from=commonswiki
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf20/includes/context/RequestContext.php(93): RequestContext::setTitle()
#1 /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.class.php(901): RequestContext->setTitle(NULL)
#2 /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.hooks.php(373): AbuseFilter::filterAction(Object(AbuseFilterVariableHolder), Object(Title))
#3 /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.hooks.php(397): AbuseFilterHooks::checkNewAccount(Object(User), '', true)
#4 [internal function]: AbuseFilterHooks::onAbortAutoAccount(Object(User), '')
#5 /usr/local/apache/common-local/php-1.22wmf20/includes/Hooks.php(199): call_user_func_array('AbuseFilterHook...', Array)
#6 /usr/local/apache/common-local/php-1.22wmf20/includes/GlobalFunctions.php(3917): Hooks::run('AbortAutoAccoun...', Array)
#7 /usr/local/apache/common-local/php-1.22wmf20/extensions/CentralAuth/CentralAuthHooks.php(812): wfRunHooks('AbortAutoAccoun...', Array)
#8 /usr/local/apache/common-local/php-1.22wmf20/extensions/CentralAuth/CentralAuthHooks.php(552): CentralAuthHooks::attemptAddUser(Object(User))
#9 [internal function]: CentralAuthHooks::onUserLoadFromSession(Object(User), NULL)
#10 /usr/local/apache/common-local/php-1.22wmf20/includes/Hooks.php(199): call_user_func_array('CentralAuthHook...', Array)
#11 /usr/local/apache/common-local/php-1.22wmf20/includes/GlobalFunctions.php(3917): Hooks::run('UserLoadFromSes...', Array)
#12 /usr/local/apache/common-local/php-1.22wmf20/includes/User.php(935): wfRunHooks('UserLoadFromSes...', Array)
#13 /usr/local/apache/common-local/php-1.22wmf20/includes/User.php(297): User->loadFromSession()
#14 /usr/local/apache/common-local/php-1.22wmf20/includes/User.php(1743): User->load()
#15 /usr/local/apache/common-local/php-1.22wmf20/includes/User.php(2847): User->getId()
#16 /usr/local/apache/common-local/php-1.22wmf20/includes/Wiki.php(524): User->isLoggedIn()
#17 /usr/local/apache/common-local/php-1.22wmf20/includes/Wiki.php(467): MediaWiki->main()
#18 /usr/local/apache/common-local/php-1.22wmf20/index.php(49): MediaWiki->run()
#19 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#20 {main}
Comment 2 Gerrit Notification Bot 2013-10-07 19:01:58 UTC
Change 88189 had a related patch set uploaded by Anomie:
Allow $context->setTitle( null )

https://gerrit.wikimedia.org/r/88189
Comment 3 Gerrit Notification Bot 2013-10-07 19:52:27 UTC
Change 88203 had a related patch set uploaded by CSteipp:
Move forceHTTPS check until after wgTitle is setup

https://gerrit.wikimedia.org/r/88203
Comment 4 Gerrit Notification Bot 2013-10-08 16:34:19 UTC
Change 88203 merged by jenkins-bot:
Move forceHTTPS check until after wgTitle is setup

https://gerrit.wikimedia.org/r/88203
Comment 5 Gerrit Notification Bot 2013-10-08 16:51:35 UTC
Change 88508 had a related patch set uploaded by Reedy:
Move forceHTTPS check until after wgTitle is setup

https://gerrit.wikimedia.org/r/88508
Comment 6 Gerrit Notification Bot 2013-10-08 18:28:31 UTC
Change 88508 merged by jenkins-bot:
Move forceHTTPS check until after wgTitle is setup

https://gerrit.wikimedia.org/r/88508
Comment 7 Gerrit Notification Bot 2013-10-08 18:30:04 UTC
Change 88189 merged by jenkins-bot:
Allow $context->setTitle( null )

https://gerrit.wikimedia.org/r/88189
Comment 8 Sam Reed (reedy) 2013-10-11 00:10:37 UTC
This is seemingly still happening... Thought I guess it's because 88189 hasn't been backported to 1.22wmf20?

Catchable fatal error:  Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.class.php on line 901 and defined in /usr/local/apache/common-local/php-1.22wmf20/includes/context/RequestContext.php on line 93
Comment 9 Chris Steipp 2013-10-11 02:50:47 UTC
The stack trace is a little different in this case, and they seem to be much less frequent. Redacted stack trace below.

Also, every trace in the logs today is from zh.wikipedia.org. Coincidence?


[11-Oct-2013 00:00:27] Catchable fatal error: Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.class.php on line 901 and defined at /usr/local/apache/common-local/php-1.22wmf20/includes/context/RequestContext.php on line 93
Server: mw1185
Method: GET
URL: http://zh.wikipedia.org/wiki/
Cookie: centralauth_User=####; centralauth_Token=##############; forceHTTPS=1
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf20/includes/context/RequestContext.php(93): RequestContext::setTitle()
#1 /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.class.php(901): RequestContext->setTitle(NULL)
#2 /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.hooks.php(373): AbuseFilter::filterAction(Object(AbuseFilterVariableHolder), Object(Title))
#3 /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.hooks.php(397): AbuseFilterHooks::checkNewAccount(Object(User), '', true)
#4 [internal function]: AbuseFilterHooks::onAbortAutoAccount(Object(User), '')
#5 /usr/local/apache/common-local/php-1.22wmf20/includes/Hooks.php(199): call_user_func_array('AbuseFilterHook...', Array)
#6 /usr/local/apache/common-local/php-1.22wmf20/includes/GlobalFunctions.php(3917): Hooks::run('AbortAutoAccoun...', Array)
#7 /usr/local/apache/common-local/php-1.22wmf20/extensions/CentralAuth/CentralAuthHooks.php(812): wfRunHooks('AbortAutoAccoun...', Array)
#8 /usr/local/apache/common-local/php-1.22wmf20/extensions/CentralAuth/CentralAuthHooks.php(552): CentralAuthHooks::attemptAddUser(Object(User))
#9 [internal function]: CentralAuthHooks::onUserLoadFromSession(Object(User), NULL)
#10 /usr/local/apache/common-local/php-1.22wmf20/includes/Hooks.php(199): call_user_func_array('CentralAuthHook...', Array)
#11 /usr/local/apache/common-local/php-1.22wmf20/includes/GlobalFunctions.php(3917): Hooks::run('UserLoadFromSes...', Array)
#12 /usr/local/apache/common-local/php-1.22wmf20/includes/User.php(935): wfRunHooks('UserLoadFromSes...', Array)
#13 /usr/local/apache/common-local/php-1.22wmf20/includes/User.php(297): User->loadFromSession()
#14 /usr/local/apache/common-local/php-1.22wmf20/includes/User.php(4593): User->load()
#15 /usr/local/apache/common-local/php-1.22wmf20/includes/User.php(2305): User->loadOptions()
#16 /usr/local/apache/common-local/php-1.22wmf20/includes/context/RequestContext.php(296): User->getOption('language')
#17 /usr/local/apache/common-local/php-1.22wmf20/includes/StubObject.php(204): RequestContext->getLanguage()
#18 /usr/local/apache/common-local/php-1.22wmf20/includes/StubObject.php(149): StubUserLang->_newObject()
#19 /usr/local/apache/common-local/php-1.22wmf20/includes/StubObject.php(98): StubObject->_unstub('getCode', 5)
#20 /usr/local/apache/common-local/php-1.22wmf20/includes/StubObject.php(197): StubObject->_call('getCode', Array)
#21 /usr/local/apache/common-local/php-1.22wmf20/includes/Message.php(386): StubUserLang->__call('getCode', Array)
#22 /usr/local/apache/common-local/php-1.22wmf20/includes/Message.php(386): StubUserLang->getCode()
#23 /usr/local/apache/common-local/php-1.22wmf20/languages/LanguageConverter.php(581): Message->inLanguage('zh-hans')
#24 /usr/local/apache/common-local/php-1.22wmf20/languages/Language.php(693): LanguageConverter->convertNamespace(-2, 'zh-hans')
#25 /usr/local/apache/common-local/php-1.22wmf20/languages/Language.php(716): Language->getNamespaceAliases()
#26 /usr/local/apache/common-local/php-1.22wmf20/languages/Language.php(741): Language->getNamespaceIds()
#27 /usr/local/apache/common-local/php-1.22wmf20/includes/Title.php(3190): Language->getNsIndex('Wikipedia')
#28 /usr/local/apache/common-local/php-1.22wmf20/includes/Title.php(152): Title->secureAndSplit()
#29 /usr/local/apache/common-local/php-1.22wmf20/includes/Title.php(375): Title::newFromText('Wikipedia:?????...')
#30 /usr/local/apache/common-local/php-1.22wmf20/includes/Wiki.php(121): Title::newMainPage()
#31 /usr/local/apache/common-local/php-1.22wmf20/includes/Wiki.php(137): MediaWiki->parseTitle()
#32 /usr/local/apache/common-local/php-1.22wmf20/includes/Wiki.php(530): MediaWiki->getTitle()
#33 /usr/local/apache/common-local/php-1.22wmf20/includes/Wiki.php(467): MediaWiki->main()
#34 /usr/local/apache/common-local/php-1.22wmf20/index.php(49): MediaWiki->run()
#35 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#36 {main}
Comment 10 Brad Jorsch 2013-10-11 13:02:29 UTC
(In reply to comment #8)
> This is seemingly still happening... Thought I guess it's because 88189
> hasn't been backported to 1.22wmf20?

Probably a good guess.

(In reply to comment #9)
> The stack trace is a little different in this case, and they seem to be much
> less frequent. Redacted stack trace below.
> 
> Also, every trace in the logs today is from zh.wikipedia.org. Coincidence?

Not a coincidence. This time the code path to unstub User before $wgTitle is set is only triggered when the wiki's content language has variants.
Comment 11 Sam Reed (reedy) 2013-10-11 19:00:44 UTC
This is getting more frequent...
Comment 12 Andre Klapper 2013-10-14 15:39:23 UTC
[Resetting to new as no patches are waiting for review anymore.]

Reedy: What does "more frequent" mean? 
How is it on other wikis than zh which have language variants?
Comment 13 Andre Klapper 2013-11-26 10:54:08 UTC
Reedy: What does "more frequent" mean? 
How is it on other wikis than zh which have language variants?
Comment 14 Andre Klapper 2014-01-09 11:42:50 UTC
Reedy: Does this still happen or can this be closed as WORKSFORME nowadays?
Comment 15 Andre Klapper 2014-08-04 00:47:16 UTC
Reedy or anybody: Does this still happen or can this be closed as WORKSFORME nowadays?
Comment 16 Andre Klapper 2014-10-21 16:32:24 UTC
Reedy or anybody: Can this still be seen or can this be closed as WORKSFORME nowadays?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links