Last modified: 2014-05-10 04:49:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57393, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55393 - VisualEditor: Wikitext diff is not regenerated if VE content is the same but the page has subsequently changed
VisualEditor: Wikitext diff is not regenerated if VE content is the same but ...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Low minor
: ---
Assigned To: Editing team bugs – take if you're interested!
: testme
Depends on:
Blocks: 55392
  Show dependency treegraph
 
Reported: 2013-10-07 03:14 UTC by John Mark Vandenberg
Modified: 2014-05-10 04:49 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2013-10-07 03:14:16 UTC
+++ This bug was initially created as a clone of Bug #55392 +++

VE caches the diff, which means if no content is changed, the user is shown
a) a stale diff and is allowed to proceed with saving the page, which means they are then
b) the page with their saved changes only
The user is unaware that they have overwritten another persons changes.

Steps to reproduce:
1. Create a page with some two lines
   https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&oldid=573748285
2. Open the page in two VE windows
3. In the second window, alter the first line and save
   https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&oldid=576079696
5. In the first window, alter the first line and review changes
   (the diff only shows the first line being modified
    against the page contents from step 3)
6. In the second window, add some lines and save
   https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&oldid=576079807
7. In the first window, review changes, and cancel the save
   (the diff is the same as in step 5; the VE page content doesnt change)
8. In the first window, save

Expected results:
In step 7, the diff should be refreshed even though the page content has not been modified.

Actual results:
The diff from step 5 is displayed in step 7.
Comment 1 MZMcBride 2013-10-07 03:56:25 UTC
This might be a Parsoid issue?
Comment 2 John Mark Vandenberg 2014-05-10 04:49:41 UTC
At bug 55392 comment 3 James says that in core mediawiki functionality "you can't edit conflict with yourself, and new edits silently over-write", which could mean this bug is also the correct behaviour.  Need to retest with two different users.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links