Last modified: 2014-08-27 11:46:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57334, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55334 - ResourceLoader didn't invalidate cached CSS correctly for Extension:CategoryTree change
ResourceLoader didn't invalidate cached CSS correctly for Extension:CategoryT...
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 54945
  Show dependency treegraph
 
Reported: 2013-10-05 08:39 UTC by Liangent
Modified: 2014-08-27 11:46 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Bad rendering (37.33 KB, image/png)
2013-10-05 08:39 UTC, Liangent
Details
Good rendering (after a force reload) (37.31 KB, image/png)
2013-10-05 08:40 UTC, Liangent
Details

Description Liangent 2013-10-05 08:39:57 UTC
Created attachment 13440 [details]
Bad rendering

HTML:

<div style="font-family: sans-serif;" dir="ltr" lang="zh-cn"><div id="mw-subcategories">
<h2>子分类</h2>
<p>本分类只有以下子分类。
</p><div style="font-family: sans-serif;" dir="ltr" class="mw-content-ltr" lang="zh"><h3>使</h3>
<ul><li><div class="CategoryTreeSection"><div class="CategoryTreeItem"><span class="CategoryTreeEmptyBullet">► </span> <a title="" class="CategoryTreeLabel  CategoryTreeLabelNs14 CategoryTreeLabelCategory" href="/wiki/Category:%E4%BD%BF%E7%94%A8%E6%97%A0%E6%95%88%E9%A2%9C%E8%89%B2%E7%9A%84%E7%94%9F%E7%89%A9%E5%88%86%E7%B1%BB%E6%A1%86">使用无效颜色的生物分类框</a>‎ <span title="含有0个子分类,129个页面和0个文件" dir="ltr">(129个页面)</span></div>
		<div class="CategoryTreeChildren" style="display:none"></div></div>
		</li></ul></div>
</div></div></div>
Comment 1 Liangent 2013-10-05 08:40:44 UTC
Created attachment 13441 [details]
Good rendering (after a force reload)
Comment 2 Krinkle 2013-10-09 17:13:58 UTC
We'll need more information (specifically the Git commit that changed this in CategoryTree) to figure out what caused it (RL not caching right, or CategoryTree using it wrong) and how to prevent it.
Comment 3 Liangent 2013-10-09 17:53:36 UTC
(In reply to comment #2)
> We'll need more information (specifically the Git commit that changed this in
> CategoryTree) to figure out what caused it (RL not caching right, or
> CategoryTree using it wrong) and how to prevent it.

I think it's 4b1eecbd1006e4f6e577dbffc61bda8adb885eac.
Comment 4 Krinkle 2013-10-09 23:03:16 UTC
The commit changes:

* i18n messages used in PHP

This means all cached pages (for anonymous users) will continue to contain the old
version for up to 30 days. This is expected behaviour by MediaWiki and Wikimedia's server configuration and not related to ResourceLoader.


* The css for the list item bullet

This module is loaded with addModuleStyles and can't be cached with a version timestamp for that reason. It is automatically invalidated every 5 minutes.


So after this was deployed:
* In the first 5 minutes:
  * logged-in users will (as usual) get fresh pages with the new i18n icon,
    but have old css cached (upto 5 minutes).
  * logged-out users will get cached pages with the old i18n icon
     and also cached css (upto 5 minutes).

* In the first 30 days, after the first 5 minutes:
  * logged-in users will see the new i18n icon with the new css.
  * logged-out users will get cached pages with the old i18n icon
    and the new css.

The only part that is ResourceLoader is that the css is cached for 5 minutes.

Are you able to see the mixed version (either logged-in or not) still now? If so, I'd like to investigate what might cause that.
Comment 5 Liangent 2013-10-10 05:12:09 UTC
I was logged in, and based on the time I don't think I was seeing that just within 5 minutes after deployment, so, it's:

In the first 30 days, after the first 5 minutes: logged-in users see the new i18n icon with (expected) the new css / (actual) the old css.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links