Last modified: 2014-09-17 11:18:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57315, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55315 - category.py breaks articles with includeonly and noinclude
category.py breaks articles with includeonly and noinclude
Status: PATCH_TO_REVIEW
Product: Pywikibot
Classification: Unclassified
category.py (Other open bugs)
unspecified
All All
: High critical
: ---
Assigned To: Pywikipedia bugs
:
: 55221 55300 55328 (view as bug list)
Depends on:
Blocks: pwb20
  Show dependency treegraph
 
Reported: 2013-10-05 05:03 UTC by Kunal Mehta (Legoktm)
Modified: 2014-09-17 11:18 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2013-10-05 05:03:54 UTC
Originally from: http://sourceforge.net/p/pywikipediabot/bugs/822/
Reported by: djbarrett
Created on: 2008-11-19 19:07:20
Subject: category.py breaks articles with includeonly and noinclude
Original description:
This is a DEADLY bug that wrecks wiki structure.

I ran "python category.py" to rename one category to another. For articles containing <includeonly> and <noinclude> statements, pywikipedia made incorrect changes.  When renaming category B to category C, the text:

<includeonly>\[\[Category:A\]\]</includeonly><noinclude>\[\[Category:B\]\]</noinclude>

becomes:

<includeonly></includeonly><noinclude></noinclude>
\[\[Category:C\]\]

In other words, it completely removed category A, and when renaming category B, placed the new category tag outside the noinclude tags.

This wrecked a complicated category structure.

$ python version.py
Pywikipedia \[http\] trunk/pywikipedia \(r6088, Nov 12 2008, 11:19:15\)
Python 2.4.3 \(\#1, May 24 2008, 13:57:05\) 
\[GCC 4.1.2 20070626 \(Red Hat 4.1.2-14\)\]
Comment 1 Kunal Mehta (Legoktm) 2013-10-05 05:03:56 UTC
- **summary**: category.py fails with includeonly and noinclude --> category.py breaks articles with includeonly and noinclude
Comment 2 Gerrit Notification Bot 2013-10-09 21:36:37 UTC
Change 88885 had a related patch set uploaded by Mpaa:
Bug 55315 - category.py breaks articles with includeonly and noinclude

https://gerrit.wikimedia.org/r/88885
Comment 3 Gerrit Notification Bot 2013-10-10 17:47:00 UTC
Change 89026 had a related patch set uploaded by Mpaa:
Bug 55315 - category.py breaks articles with includeonly and noinclude

https://gerrit.wikimedia.org/r/89026
Comment 4 Mpaa 2013-10-25 16:25:49 UTC
*** Bug 55300 has been marked as a duplicate of this bug. ***
Comment 5 Mpaa 2013-10-25 16:30:43 UTC
*** Bug 55221 has been marked as a duplicate of this bug. ***
Comment 6 Mpaa 2013-10-25 16:36:23 UTC
*** Bug 55328 has been marked as a duplicate of this bug. ***
Comment 7 Gerrit Notification Bot 2014-05-26 08:04:21 UTC
Change 88885 abandoned by Ladsgroup:
Bug 55315 - category.py breaks articles with includeonly and noinclude

https://gerrit.wikimedia.org/r/88885
Comment 8 John Mark Vandenberg 2014-09-17 11:03:57 UTC
This patch is still not merged:
https://gerrit.wikimedia.org/r/#/c/89026/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links