Last modified: 2014-04-17 22:52:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56989, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54989 - TiffHandler broken under hhvm?
TiffHandler broken under hhvm?
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-04 19:53 UTC by Chad H.
Modified: 2014-04-17 22:52 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chad H. 2013-10-04 19:53:07 UTC 
Haven't managed to diagnose exactly what's going wrong here, but wanted to file a bug for tracking.

Currently on hhvm, TiffTest::testTiffMetadataExtraction() is failing. The call to getMetadata() is returning ExifBitmapHandler::BROKEN_FILE for the test file. The failure ends up looking like:

$ hhvm phpunit.php includes/media/TiffTest.php 
PHPUnit 3.7.23 by Sebastian Bergmann.

Configuration read from /www/mediawiki/core/tests/phpunit/suite.xml

.E.

Time: 106 ms, Memory: 7.91Mb

There was 1 error:

1) TiffTest::testTiffMetadataExtraction
Unable to unserialize: [-1]. Expected ':' but got '1'.

/www/mediawiki/core/tests/phpunit/includes/media/TiffTest.php:29
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

FAILURES!
Tests: 3, Assertions: 2, Errors: 1.

Current hhvm info:
$ hhvm --version
HipHop VM v2.1.0-dev (rel)
Compiler: heads/master-0-g5e0cd6a795a31c28adce6739e1d021635a0f8dbd
Repo schema: d1d216e056958e39b9aec248c8e310b70d536466
Comment 1 Bawolff (Brian Wolff) 2013-10-04 20:05:12 UTC 
I believe it uses php's exif extension. My first (blind, without looking at src or debugging anything) guess would be that hiphop doesn't support that extension.
Comment 2 Chad H. 2013-10-04 20:36:50 UTC 
extension_loaded( 'exif' ) returns false (upstream issue, will report), but we've definitely got exif support. Checking get_defined_functions() gives us all of:

exif_imagetype
exif_read_data
read_exif_data
exif_tagname
exif_thumbnail
Comment 3 Chad H. 2013-10-04 22:02:06 UTC 
(In reply to comment #2)
> extension_loaded( 'exif' ) returns false (upstream issue, will report)
> 

I lied, looks like that's all correct too. So yeah, dunno if it's on our end or if hhvm isn't behaving.
Comment 4 Rob Lanphier 2013-10-10 17:54:39 UTC 
(speaking with my Multimedia team hat on)  We'll leave this one for the MediaWiki Core group to handle if it isn't already fixed by the time the HipHop migration starts in earnest.
Comment 5 Andre Klapper 2014-01-10 00:38:23 UTC 
[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]
Comment 6 Aaron Schulz 2014-04-17 22:52:05 UTC 
Works in hhvm 3.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links