Last modified: 2014-04-28 17:40:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56921, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54921 - VisualEditor: Make the isRedirect disable check look at the revision being considered, not current revision
VisualEditor: Make the isRedirect disable check look at the revision being co...
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Low minor
: ---
Assigned To: Editing team bugs – take if you're interested!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-03 15:15 UTC by Chris McKenna
Modified: 2014-04-28 17:40 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chris McKenna 2013-10-03 15:15:23 UTC 
When a page is currently a redirect, but has none-redirect versions in its history those versions should be editable in VE but are not. e.g. https://en.wikipedia.org/w/index.php?title=Equality_Acts&oldid=570457856

To reproduce:
1. Load any page that is not a redirect in the source editor
2. Change the page into a redirect and save
3. View any revision prior to the redirect

Expected behaviour: Old version is editable in VE
Action behaviour: No option is given to edit in VE
Comment 1 James Forrester 2013-10-03 21:00:30 UTC 
Will be superseded by bug 50878 once bug 47328 is implemented, but could be done sooner if someone is keen.
Comment 2 Alex Monk 2014-01-29 00:50:21 UTC 
I'm not sure how easy this would be to do... It appears to be based on MediaWiki core's wgIsRedirect, which would need fixing to work out whether the current revision is a redirect (instead of the latest revision of the current page). I'm not sure core even has a function to work that out at the moment. Even in the database, the field to determine if something is a redirect is in the page table instead of the revision table.
Comment 3 James Forrester 2014-04-28 17:40:03 UTC 
We no longer stop editing of isRedirect pages, so marking as INVALID now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links