Last modified: 2013-10-03 14:41:09 UTC
Grepping through the code shows no use of this variable outside of its declaration. It certainly doesn't remove the login link.
It looks like the name was changed to $wgHideOpenIDLoginLink. Setting $wgHideOpenIDLoginLink=true hides the link correctly. https://www.mediawiki.org/wiki/Extension:OpenID#Configuration references the correct name.
Thanks for reporting. All OpenID parameter names should have the form $wgOpenID...... It appears, that the renaming of this specific variable has been overlooked in the past. I will fix this begin of October. Sorry for the inconvenience.
The bug is still a bug, it's not invalid. If the name should be $wgHideOpenIDLoginLink, then that should be listed in OpenID.php and $wgOpenIDHideOpenIDLoginLink shouldn't be. And if the name should be $wgOpenIDHideOpenIDLoginLink, then $wgHideOpenIDLoginLink needs to be replaced in the code and the documentation.
fixed, tested, merged, closed
solved with https://gerrit.wikimedia.org/r/#/c/87321/ (why is gerrit not adding this information any more ?)
(In reply to comment #5) > solved with https://gerrit.wikimedia.org/r/#/c/87321/ (why is gerrit not > adding this information any more ?) Because you did not follow http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines
http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines : added there "No text must follow the bugnumber. "
