Last modified: 2013-09-24 04:15:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56487, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 54487 - Non voting failing php unit tests


Summary:	Non voting failing php unit tests

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized critical (vote)
Target Milestone:	---
Assigned To:	Antoine "hashar" Musso (WMF)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-09-24 01:34 UTC by physikerwelt
Modified:	2013-09-24 04:15 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description physikerwelt 2013-09-24 01:34:18 UTC

Jenkins votes with +2 even if PHP-Unit test fail.
See e.g. latest commits in the Math extension. https://gerrit.wikimedia.org/r/#/c/85801/
I would vote that jenkins only gives +2 if all test were successful. And -1 if there are failed tests.
If there are skipped test (e.g. because jenkins can not write to the database) a +1 was fine but +2 gives a wrong impression.
This indicates for a reviewer that he should run the tests locally to vote with +2 for verification.

Comment 1 Antoine "hashar" Musso (WMF) 2013-09-24 04:09:35 UTC

Oh i did not notice the test were passing at some point. Kudos! Enabling voting right now.

Comment 2 Gerrit Notification Bot 2013-09-24 04:11:05 UTC

Change 85822 had a related patch set uploaded by Hashar:
mwext-Math-testextensions-master are now voting

https://gerrit.wikimedia.org/r/85822

Comment 3 Gerrit Notification Bot 2013-09-24 04:12:07 UTC

Change 85822 merged by jenkins-bot:
mwext-Math-testextensions-master are now voting

https://gerrit.wikimedia.org/r/85822

Comment 4 Antoine "hashar" Musso (WMF) 2013-09-24 04:14:17 UTC

Deployed :-) That made Jenkins unhappy on https://gerrit.wikimedia.org/r/#/c/85801/

Congratulations!

Comment 5 physikerwelt 2013-09-24 04:15:00 UTC

Thanks!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links