Last modified: 2013-10-05 20:47:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56392, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54392 - No continue button in IE 8 for UploadWizard
No continue button in IE 8 for UploadWizard
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
PC Windows XP
: High major (vote)
: ---
Assigned To: Rainer Rillke @commons.wikimedia
: code-update-regression
Depends on:
Blocks: 42164
  Show dependency treegraph
 
Reported: 2013-09-20 18:07 UTC by Rainer Rillke @commons.wikimedia
Modified: 2013-10-05 20:47 UTC (History)
5 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rainer Rillke @commons.wikimedia 2013-09-20 18:07:00 UTC
Steps to reproduce:
0) Use Internet Explorer 8
1) Log In at Commons
2) Go to https://commons.wikimedia.org/wiki/Special:UploadWizard
3) Select a file to upload
4) File uploads
5) But there is no continue-button

Expected result:
Continue-button after the file successfully uploaded. I can confirm that the upload succeeded by inspecting [[Special:UploadStash]].

There are various reports. Some of them at [[:commons:COM:FORUM]], [[:commons:COM:UH]], [[:commons:COM:HD]]
Comment 1 Andre Klapper 2013-09-20 18:45:48 UTC
I see 
https://commons.wikimedia.org/wiki/Commons:FORUM#Datei_hochladen:_Der_der_.22Weiter.22-Button_fehlt. misses enough information. 
https://commons.wikimedia.org/wiki/Commons:UH#My_broken_Upload_Wizard
but I fail to find the strings "contin" or "button" on :HD.
Comment 2 Rainer Rillke @commons.wikimedia 2013-09-20 19:57:50 UTC
(In reply to comment #1)
People have different wayes to express 

"at I choose the file, the start uploading, then I see the minimalized photography. but there is no icony "Further" (or Go on - i don't know how it in English version but in Polish it is "Dalej")"

With "Further", it is clear that the "continue button" is missing. It's always hard to describe something that is missing.

Is it not sufficient that I could reproduce this issue and identified the cause?
https://github.com/wikimedia/mediawiki-extensions-UploadWizard/commit/325b5ce20e82d00594480f10f749379c3549a65e#L15R720

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind sais that function.prototype.bind does not exist in IE 8.


HD (this was just archived): https://commons.wikimedia.org/wiki/Commons:Help_desk/Archive/2013/09#Software_error.3F
Comment 3 Gerrit Notification Bot 2013-09-20 20:24:16 UTC
Change 85324 had a related patch set uploaded by Rillke:
Replacing function.prototype.bind with jQuery.proxy

https://gerrit.wikimedia.org/r/85324
Comment 4 Nemo 2013-09-20 20:41:07 UTC
Thanks. I have reports of this bug from attempted WLM participants. I'll tell them not to use Internet Explorer, but this is quite problematic.
Comment 5 Rainer Rillke @commons.wikimedia 2013-09-21 09:14:49 UTC
I am going to install a polyfill at Commons. Prototype already has an implementation of that: http://prototypejs.org/doc/latest/language/Function/prototype/bind/
Comment 6 Rainer Rillke @commons.wikimedia 2013-09-21 09:37:39 UTC
This is also an issue for:
* Chrome < 7
* Opera < 11.60
* Safari < 5.1.4
Comment 7 Rainer Rillke @commons.wikimedia 2013-09-21 10:30:07 UTC
Fixed locally at Commons by adding a polyfill: https://commons.wikimedia.org/wiki/MediaWiki:BindPolyfill.js
Comment 8 Andre Klapper 2013-09-22 12:54:05 UTC
(In reply to comment #2)
> Is it not sufficient that I could reproduce this issue and identified the
> cause?

The identified cause wasn't mentioned in comment 0 but it is in comment 2. 
Thanks for tracking that down!
Comment 9 Nemo 2013-09-23 11:26:22 UTC
(In reply to comment #7)
> Fixed locally at Commons by adding a polyfill:
> https://commons.wikimedia.org/wiki/MediaWiki:BindPolyfill.js

Thanks, I have reports from the same users that it now works with IE8.
Comment 10 Gerrit Notification Bot 2013-10-05 19:39:46 UTC
Change 85324 merged by jenkins-bot:
Replacing Function.prototype.bind with anonymous function

https://gerrit.wikimedia.org/r/85324
Comment 11 Rainer Rillke @commons.wikimedia 2013-10-05 20:47:44 UTC
Fixed in MASTER branch but not yet deployed to the cluster.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links