Last modified: 2006-04-04 02:42:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7432, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 5432 - Incorrect cookie prefix leads to problems with persistent logins


Summary:	Incorrect cookie prefix leads to problems with persistent logins

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	User login and signup (Other open bugs)
Version:	1.6.x
Hardware:	PC All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-04-02 20:17 UTC by Ilya Schurov
Modified:	2006-04-04 02:42 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
quick and dirty patch (1.88 KB, patch) 2006-04-02 20:19 UTC, Ilya Schurov	Details
Add an attachment (proposed patch, testcase, etc.)

Description Ilya Schurov 2006-04-02 20:17:52 UTC

If $wgDBprefix is set and $wgCookiePrefix not equal to $wgDBname, problem with
persistent logins occurs (i.e. the system doesn't remember user even if
appropriate options is set). In file includes/User.php the system tries to use
$wgDBname as cookie prefix on setting and then $wgCookiePrefix on getting the
cookie. 

See also bug #1396.

Comment 1 Ilya Schurov 2006-04-02 20:19:49 UTC

Created attachment 1494 [details]
quick and dirty patch

Proposed patch looks to solve the problem, but not yet well tested.

Comment 2 Brion Vibber 2006-04-03 00:55:02 UTC

Fixed in trunk, r13436. Per patch, plus fixes in User::logout().

Comment 3 Ilya Schurov 2006-04-03 18:37:36 UTC

OK, thanks. How long does it takes for fix to appear in current CVS version?

Comment 4 Rob Church 2006-04-03 19:30:43 UTC

We're no longer using CVS due to SourceForge's unannounced and unexplained
downtime. The SVN repo is now maintained at http://svn.wikimedia.org and there's
no lag for anonymous reads. More information at
http://www.mediawiki.org/wiki/Subversion.

Comment 5 Ilya Schurov 2006-04-03 21:26:33 UTC

Thanks, Rob. BTW, there's no any notes about SVN on
http://www.mediawiki.org/wiki/Download -- is it just temporarily situation and
will be fixed soon?

Comment 6 Rob Church 2006-04-04 02:42:48 UTC

Brion's in the process of updating that documentation, etc. now.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links