Last modified: 2014-11-17 10:59:17 UTC
Created attachment 13318 [details] mobile watchlist icon Desktop icon should be replaced to match mobile skin
Created attachment 13319 [details] desktop watchlist icon
The above screenshot also confirms that the Vector watch star icon is not ready for high-resolution displays (Retina/Hi-DPI). Adding to tracking bug 32101 (hi-dpi issues) so we don't forget to fix that with the update!
They don't match because the skins are different, lol. I'm inclined to WONTFIX this. Moving to appropriate component.
The proposal is "Desktop icon should be replaced to match mobile skin", not the other way around. Therefore it's a request for MediaWiki Core / Skins. Moving back. Even if the themes are different, I personally see a point in sharing the same star icon, if only because the current desktop star is not precisely impressive. As other bugs mention, it's PNG only and problematic in high definition displays. In any case a designer should propose the exact replacements for http://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/skins%2Fvector%2Fimages%2Fwatch-icons.png http://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/skins%2Fvector%2Fimages%2Fwatch-icon-loading.gif Mockups / tests to see how the new star would look like would be useful as well.
Assigning to May for Design, then Eng.
Created attachment 13413 [details] Watch icon
Created attachment 13414 [details] Unwatch icon
Updated (Hi-DPI compatible) assets attached by May, anyone who wants to integrate these assets, help would be appreciated.
As said in comment #4, I believe engineers expect a single file with 4 stars (each one for a different status) + an animated image, to substitute cleanly what exists now. Check the links. The more you diverge from this the more programming work will be needed. But I'm just an observer here and I might be wrong.
Quoting Daniel Friesen at bug 35335: "The animation is nothing but a spin, right? Instead of trying to continue using horrible gifs or animate SVG in a way that probably won't be supported. How about we try using css? Most browsers with .svg support should support css3-animations."
The mobile site does use css3 animations (in beta) to do exactly this and could be reused for this purpose.
side note: should there be a tracking bug - make mobile web skin consistent with desktop web skin. This might clarify if the "why" we might be doing this...
Please use assets from https://bugzilla.wikimedia.org/show_bug.cgi?id=35335
This is a simple task. However, is there a consensus about the plan? Should the desktop star look like the mobile star or the other way around? (In reply to comment #10) > Quoting Daniel Friesen at bug 35335: > > "The animation is nothing but a spin, right? Instead of trying to continue > using > horrible gifs or animate SVG in a way that probably won't be supported. How > about we try using css? > Most browsers with .svg support should support css3-animations." For what is worth there is a patch (from a GCI student) waiting for reviewers at Bug 35335 - https://gerrit.wikimedia.org/r/#/c/99258/
At this point, isn't this report a duplicate of bug 35335, which has a patch ready to be merged?
It probably isn't since that patch doesn't change the look of the icon, just vectorizes it.
Yes, but the same action/asset fixes both bugs, either way we're talking way too much about a bug that is really trivial and probably doesn't deserve this much discussion. If someone swaps the assets we can close two bugs.
Comment on attachment 13414 [details] Unwatch icon deprecated in favor of Wikifont assets
Comment on attachment 13413 [details] Watch icon deprecated in favor of Wikifont assets
Still unclear to me what a new contributor is expected to do here nowadays, cf. comment 14. And bug 35335 has been FIXED too in the meantime. Could somebody please elaborate (and add the "easy" keyword back again once the expected remaining work is clearly described)? Thanks.
This has come up again as an accessibility issue for colorblind users, there is no longer a wikifont dependency, and the assets should be the same between desktop and mobile web.
This should be ready as a GSOC task now.
