Last modified: 2014-08-15 12:02:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 54197 - Archiving of feedback broken on enwiki
Archiving of feedback broken on enwiki
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
master
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 43421 61089
  Show dependency treegraph
 
Reported: 2013-09-17 00:15 UTC by Sam Reed (reedy)
Modified: 2014-08-15 12:02 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2013-09-17 00:15:28 UTC
Archiving disabled in https://gerrit.wikimedia.org/r/#/c/84469/

Archiving seems to be broken as the bot/job is repeatedly archiving the same set of feedback, but the items haven't been archived.

Relatedly, the log entry should only be created if archiving actually succeeded


01:13 	(Article feedback activity log)‎ . . [Article Feedback V5‎ (57×)]
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
      	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
Comment 1 Sam Reed (reedy) 2013-09-17 00:20:03 UTC
Log for anyone interested https://en.wikipedia.org/wiki/Special:Log/articlefeedbackv5
Comment 3 Matthias Mullie 2013-09-30 16:03:33 UTC
Brain dump:

Looking at e.g. feedback #755805 (https://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Cloud_computing/755805), this feedback entry is actually archived. DB data confirms: aft_archive = 1.

Only the maintenance script, which has since been killed, can mark feedback as archived. Activity log confirms the last action was performed by Article Feedback v5.

Where-condition, executed against slave, is: array( 'aft_archive = 0', "aft_archive_date <= '$now'" ). This means that this post should no longer appear when queried for "posts to be archived".

I'd say that perhaps slave is/was lagging, but the wait is right there in the code, and I'll assume it works:
    wfWaitForSlaves( false, false, $wgArticleFeedbackv5Cluster );
Also, the script had been going at it for 10+ minutes (another feedback entry for even way longer) until it was killed, so that lag would have to have been pretty bad. This is a highly unlikely cause.

It looks like the archiving kicked in right after a person manually un-archived the feedback.
*ERROR #1*: archive date should be re-calculated after a person un-archives feedback (or nulled completely), not be the original archive date (which results in immediate re-archive).

(probably unrelated) *ERROR #2*: maintenance script nulls aft_archive_date, but the subsequent update() call will fill out that value again.

Have to run for now, will get these fixed and continue figuring out why exactly archive broke.
Comment 4 MZMcBride 2013-12-02 06:52:56 UTC
Fabrice or Matthias: is anyone actively working on this issue? If not, it may make sense to disable AFTv5 on Wikimedia wikis if it can't be actively maintained.

For reference: <https://www.mediawiki.org/wiki/Article_feedback/status#2013-10-monthly>.
Comment 5 Nemo 2013-12-02 06:59:50 UTC
(In reply to comment #4)
> Fabrice or Matthias: is anyone actively working on this issue? If not, it may
> make sense to disable AFTv5 on Wikimedia wikis if it can't be actively
> maintained.

Seconded. If I'm not mistaken, there is no longer any "Archive" filter anywhere: it seems ArticleFeedbackv5AutoArchiveEnabled controls both past and future archival, so that setting it false actually de-archived humongous masses of unreviewed feedback, with all the vandalism they include.
Comment 6 Nemo 2014-02-11 08:17:03 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Fabrice or Matthias: is anyone actively working on this issue? If not, it may
> > make sense to disable AFTv5 on Wikimedia wikis if it can't be actively
> > maintained.
> 
> Seconded. If I'm not mistaken, there is no longer any "Archive" filter
> anywhere: it seems ArticleFeedbackv5AutoArchiveEnabled controls both past and
> future archival, so that setting it false actually de-archived humongous
> masses
> of unreviewed feedback, with all the vandalism they include.

After two more months of useless waiting, this is now finally proceeding: https://gerrit.wikimedia.org/r/#/c/112639/ , bug 61163.
Comment 7 Andre Klapper 2014-02-28 16:37:18 UTC
[Lowering priority to reflect reality, as AFTv5 is not very actively being worked on anymore.]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links