Last modified: 2014-07-18 00:02:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56163, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54163 - Port wmerrors / php-fatal-error.html to HHVM
Port wmerrors / php-fatal-error.html to HHVM
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Normal enhancement (vote)
: ---
Assigned To: Max Semenik
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-16 09:33 UTC by Ori Livneh
Modified: 2014-07-18 00:02 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2013-09-16 09:33:21 UTC
I'm not sure how much of wmerrors need to be ported. HHVM appears to enhance PHP's error reporting capabilities in various (alas, mostly undocumented) ways, so perhaps some of the fancy footwork in wmerrors won't need to be ported. But at minimum, php-fatal-error.html should work.

See onFatalError, onUnhandledException in hphp/runtime/base/execution-context.cpp

<https://github.com/facebook/hiphop-php/blob/4eb05b745fd3018a6d9e51464cae06a4465ee142/hphp/runtime/base/execution-context.cpp>
Comment 2 Andre Klapper 2014-01-10 00:38:25 UTC
[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]
Comment 3 Max Semenik 2014-03-22 00:39:01 UTC
Looks like in HHVM we don't need to code our own extension to achieve both of wmerrors goals:

* Logging stacktraces is configurable, e.g. https://gerrit.wikimedia.org/r/120162
* Fancy error pages are doable by pointing ErrorDocument500 to a PHP file that uses error_get_last() to display the needed information.

Ping me when we will have a Puppet module for production and I'll help with configuring this.
Comment 4 Max Semenik 2014-03-22 01:49:43 UTC
https://gerrit.wikimedia.org/r/#/c/120180/
Comment 5 Aaron Schulz 2014-03-23 21:43:26 UTC
Max, feel like assigning this to yourself?
Comment 6 Max Semenik 2014-03-23 22:32:27 UTC
Is there anything left to assign?:)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links