Last modified: 2014-01-10 00:38:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56158, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54158 - Make RedisConnectionPool & RedisBagOStuff compatible with HHVM's Redis extension
Make RedisConnectionPool & RedisBagOStuff compatible with HHVM's Redis extension
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.22.0
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
https://github.com/facebook/hiphop-ph...
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-16 06:14 UTC by Ori Livneh
Modified: 2014-01-10 00:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2013-09-16 06:14:33 UTC
MediaWiki's Redis integration currently requires the phpredis extension, which is not available for HHVM. HHVM 2.1.0 includes a pure-PHP Redis extension (see /hphp/system/php/redis, added in <https://github.com/facebook/hiphop-php/commit/2811e9da>). We should attempt to make MediaWiki compatible with both client libraries.
Comment 1 Gerrit Notification Bot 2013-09-19 17:19:41 UTC
Change 85003 had a related patch set uploaded by Ori.livneh:
Allow RedisConnectionPool to be used with HHVM's Redis library

https://gerrit.wikimedia.org/r/85003
Comment 2 Gerrit Notification Bot 2013-09-19 17:25:53 UTC
Change 85003 merged by jenkins-bot:
Allow RedisConnectionPool to be used with HHVM's Redis library

https://gerrit.wikimedia.org/r/85003
Comment 3 Ori Livneh 2013-09-19 17:26:51 UTC
We should have unit tests in core for these classes, but that's a separate bug.
Comment 4 Andre Klapper 2014-01-10 00:38:28 UTC
[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links