Last modified: 2014-05-15 11:27:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56033, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54033 - Files/images should be fetched in batch by parser, not one at a time
Files/images should be fetched in batch by parser, not one at a time
Status: NEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.22.0
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks: 64056
  Show dependency tree / graph
 
Reported: 2013-09-11 20:28 UTC by Brion Vibber
Modified: 2014-05-15 11:27 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2013-09-11 20:28:06 UTC 
File objects are looked up in the Parser one at a time as they're encountered. This isn't too bad on Wikimedia sites because all the file repositories are on the local network, but for third-party sites running with InstantCommons on, pages with lots of images can take a *long* time to render.

Parser::fetchFileNoRegister() does an individual wfFindFile() call. It could be *much* more efficient to call RepoGroup::findFiles() in batches; for InstantCommons images this would allow for batching the API requests, reducing the round-trip time significantly.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links