Last modified: 2014-02-25 16:54:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55710, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53710 - Oracle: import doesn't work; insert category fails
Oracle: import doesn't work; insert category fails
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Export/Import (Other open bugs)
1.22.0
All All
: Normal major (vote)
: 1.22.x release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: oracle
  Show dependency tree / graph
 
Reported: 2013-09-03 13:16 UTC by Peter Bena
Modified: 2014-02-25 16:54 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
mah: Backport_to_Stable+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Bena 2013-09-03 13:16:57 UTC 
Importing pages...

Import failed: A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script Query: INSERT INTO /*Q*/CATEGORY (cat_title,cat_pages,cat_subcats,cat_files) VALUES (:cat_title, :cat_pages, :cat_subcats, :cat_files) Function: DatabaseOracle::insertOneRow Error: 1400 ORA-01400: cannot insert NULL into ("WIKI"."CATEGORY"."CAT_ID")
Comment 1 Peter Bena 2013-09-03 13:20:05 UTC 
It seems that category inserting is completely broken :o
Comment 2 db [inactive,noenotif] 2013-09-08 09:29:32 UTC 
the category count was changed with Gerrit change #66999. Getting a new sequence was removed there (or should be done by the upsert).
Comment 3 John Mark Vandenberg 2013-12-13 04:06:15 UTC 
I havent tried to reproduce this yet, but I suspect it is still a bug, and affects any addition of a category (i.e. not just import/export).

Database::upsert() calls ::insert() , which in DatabaseOracle doesnt add the sequence using ::getSequenceData()
Comment 4 Nemo 2013-12-30 09:29:30 UTC 
Update per https://www.mediawiki.org/w/index.php?title=MediaWiki_1.22/Known_issues&oldid=847749 which seems to be the master list.
Comment 5 Gerrit Notification Bot 2014-02-03 20:27:25 UTC 
Change 110991 had a related patch set uploaded by Umherirrender:
Add sequence support for upsert in DatabaseOracle

https://gerrit.wikimedia.org/r/110991
Comment 6 Gerrit Notification Bot 2014-02-25 00:49:34 UTC 
Change 110991 merged by jenkins-bot:
Add sequence support for upsert in DatabaseOracle

https://gerrit.wikimedia.org/r/110991
Comment 7 Umherirrender 2014-02-25 14:37:44 UTC 
was successfully merged

target release is 1.22 -> flag for backport
Comment 8 Gerrit Notification Bot 2014-02-25 16:49:00 UTC 
Change 115395 had a related patch set uploaded by MarkAHershberger:
Add sequence support for upsert in DatabaseOracle

https://gerrit.wikimedia.org/r/115395
Comment 9 Gerrit Notification Bot 2014-02-25 16:54:08 UTC 
Change 115395 merged by jenkins-bot:
Add sequence support for upsert in DatabaseOracle

https://gerrit.wikimedia.org/r/115395
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links