Last modified: 2014-04-03 11:34:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55706, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53706 - VisualEditor: Incorrect text selection with jquery.IME
VisualEditor: Incorrect text selection with jquery.IME
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Language (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks: ve-multi-lingual 53014
  Show dependency treegraph
 
Reported: 2013-09-03 12:13 UTC by Siddhartha Ghai
Modified: 2014-04-03 11:34 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of selection error (21.60 KB, image/png)
2013-09-03 12:13 UTC, Siddhartha Ghai
Details
Screenshot for comment 3 (875.16 KB, image/jpeg)
2013-09-21 11:47 UTC, Siddhartha Ghai
Details

Description Siddhartha Ghai 2013-09-03 12:13:36 UTC
Created attachment 13222 [details]
Screenshot of selection error

System environment:
Win 7 X64
Google Chrome 29.0.1547.62 m

Steps to reproduce:
Open a blank page
Edit it in VE
Enable ULS IME hindi transliteration

Input:
[RETURN/ENTER KEY]x4 (four newlines)
agar[SPACE]

Expected output:
[NEWLINE]x4 (four newlines)
अगर[SPACE]

no text selection should be there

Actual output:
[NEWLINE]x4 (four newlines)
अगर[SPACE]

the ending [SPACE] is selected with a newline. Also, the toolbar shows that VE has somehow jumped to changing the formatting to bulleted and numbered list from the original paragraph formatting.

Further, pressing a backspace deletes not only the selected space/newline, but also the typed text अगर. I think this is Bug 53705 though I may be wrong.
Comment 1 D Chan 2013-09-11 23:43:40 UTC
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
Comment 2 Siddhartha Ghai 2013-09-18 12:51:26 UTC
(In reply to comment #1)
> There's code to address this bug in the following patch, which is due to go
> live by mediawiki.org on 13 September 2013:
> 
> https://gerrit.wikimedia.org/r/#/c/82858/
> 
> Please let us know whether it fixes the bug!

The patch doesn't fix the bug.

System environment:
Win 7 X64 SP1
Google Chrome 29.0.1547.66 m

Test URL:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai?veaction=edit

Steps:
Enable ULS IME hi transliteration
Blank the page and reset the formatting to simple paragraph
Follow the input steps described in Comment 0

Result:
The output is the same as described in Comment 0 as far as content selection is concerned. The formatting however, instead of changing to bulleted and numbered list, has gone blank. The formatting dropdown shows no value and no button in the VE toolbar is selected.

Pressing backspace still deletes the space and the word. It also resets the formatting to paragraph.
Comment 3 Siddhartha Ghai 2013-09-21 11:40:46 UTC
Per https://bugzilla.wikimedia.org/show_bug.cgi?id=53708#c8 the following report is for the bug behaviour when tested on a page with pre-existing text:

System Environment:
Windows7 X64 SP1
Google Chrome 29.0.1547.66 m

Test Url:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai/sandbox?veaction=edit

Steps:
Take a caret to the end of the first paragraph using the mouse (i.e click at the end of the first paragraph to take the caret there.)
Input ag

Expected output:
अग्

Actual output:
अग् but with the newline after it selected, although the newline or space wasn't typed in this edit and existed previously.
Comment 4 Siddhartha Ghai 2013-09-21 11:47:41 UTC
Created attachment 13338 [details]
Screenshot for comment 3
Comment 5 Siddhartha Ghai 2013-09-21 11:57:53 UTC
Note: Comment 3 is ofcourse with ULS IME hindi transliteration enabled.
Comment 6 Siddhartha Ghai 2013-09-21 12:30:38 UTC
Further testing Comment 3 seems to indicate that the newline selection happens when the last input is a consonant followed by a halant which can be input with one keystroke.

The hindi transliteration IME inputs two characters whenever an ASCII consonant is input, the equivalent hindi consonant followed by the halant character ् (U+094D)

So inputting g gives ग् i.e ग + ् , j gives ज् i.e ज + ् etc. with the newline selected.

Some hindi consonants, however, need two keystrokes to be input. So gh gives घ् i.e घ + ् and jh gives झ् i.e झ + ् etc. Output for these depends on the input speed. If one is quick, the text is input correctly with no selection. However, if one is slow, Bug 54421 shows up with the grapheme containing the duplicated text at the beginning of the article being selected.

This selection (or non-selection) behaviour takes place regardless of whether the input is one consonant or a word. The behaviour depends on what the last consonant is, one that can be input with one keystroke or one that is input with two keystrokes.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links