Last modified: 2013-12-18 22:39:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55453, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53453 - UploadWizard has a logging library with the same object name as core
UploadWizard has a logging library with the same object name as core
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 49987
  Show dependency tree / graph
 
Reported: 2013-08-28 03:46 UTC by Matthew Flaschen
Modified: 2013-12-18 22:39 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2013-08-28 03:46:38 UTC 
UploadWizard has its own logging library (mw.Log.js) that creates an object/function (mw.log) with the exact same name as core (resources/mediawiki/mediawiki.log.js).

The quick fix is to rename UploadWizard's.  Better is to get rid of UploadWizard's and use core's.
Comment 1 Mark Holmquist 2013-08-28 05:37:22 UTC 
https://gerrit.wikimedia.org/r/#/c/79917/
Comment 2 Gerrit Notification Bot 2013-08-28 05:37:38 UTC 
Change 79917 had a related patch set uploaded by MarkTraceur:
No need to use custom mw.log anymore

https://gerrit.wikimedia.org/r/79917
Comment 3 Gerrit Notification Bot 2013-12-18 22:36:45 UTC 
Change 79917 merged by jenkins-bot:
No need to use custom mw.log anymore

https://gerrit.wikimedia.org/r/79917
Comment 4 Mark Holmquist 2013-12-18 22:39:28 UTC 
Woohoo.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links