Last modified: 2014-07-21 06:32:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55353, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 53353 - migrate all .pep8 files content to setup.cfg


Summary:	migrate all .pep8 files content to setup.cfg

Status:	NEW

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Low enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:	44443 53352
Blocks:	53354
	Show dependency tree / graph

Reported:	2013-08-26 15:32 UTC by Antoine "hashar" Musso (WMF)
Modified:	2014-07-21 06:32 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2013-08-26 15:32:37 UTC

pep8 1.4 now supports reading configuration parameters from a 'pep8' section in tox.ini.  That would let us get rid of the .pep8 files in the repositories and have all the tools configured in a single file.

We need pep8 v1.4+ to be deployed on the Jenkins slaves first (bug 53352)

Comment 1 Antoine "hashar" Musso (WMF) 2013-09-03 12:40:15 UTC

pep8 v1.4.5 has been deployed on the slaves (was bug 53352)

Comment 2 Antoine "hashar" Musso (WMF) 2014-02-17 16:46:49 UTC

From a discussion we had with Bryan Davis, the flake8/pep8 configuration should be in setup.cfg.

Comment 3 Jean-Fred 2014-03-17 19:28:49 UTC

(In reply to Antoine "hashar" Musso from comment #2)
> From a discussion we had with Bryan Davis, the flake8/pep8 configuration
> should be in setup.cfg.

It was my understanding that flake8 and pep8 will not consider setup.cfg if there is a tox.ini file. Or will they?

Comment 4 Antoine "hashar" Musso (WMF) 2014-03-19 10:22:17 UTC

(In reply to Jean-Fred from comment #3)
> It was my understanding that flake8 and pep8 will not consider setup.cfg if
> there is a tox.ini file. Or will they?

Was apparently a bug in pep8 which got fixed with pep8 1.4.6. From its change log at https://pypi.python.org/pypi/pep8:

------------------
When both a tox.ini and a setup.cfg are present in the project directory, merge their contents. The tox.ini file takes precedence (same as before). (Issue #182)
------------------

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links