Last modified: 2013-08-20 20:55:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55116, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53116 - hideBanner not correctly working on HTTPS notice
hideBanner not correctly working on HTTPS notice
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: James Alexander
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-20 20:25 UTC by Greg Grossmeier
Modified: 2013-08-20 20:55 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Greg Grossmeier 2013-08-20 20:25:31 UTC
multiple reports coming in via IRC.

The banner can be hiden on one page, but as soon as another page is opened, it reappears.

I can confirm this on enwiki.

The notice in question (generic maintenance one):
https://meta.wikimedia.org/wiki/CentralNotice/Generic_maintenance_notice
Comment 1 Bartosz Dziewoński 2013-08-20 20:40:21 UTC
Apparently it's because the banner is marked as "emergency", see bug 17108 comment 8.

https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&method=listNoticeDetail&notice=Generic+maintenance+notice
Comment 2 James Alexander 2013-08-20 20:55:30 UTC
ok,

So I've turned off the banner for now to let the cache clear but I've also fixed the issue. When I turn it back on in 15 minutes or so (give it time to clear then test it quickly obviously if I screwed something off I'll wait another 10 minutes after fixing it) it will be hideable.

The fact is indeed the emergency nature which needs it's own individual cookie set up. We have a red warning box on Special:CentralNotice about that but it may not be obvious enough (this is supposed to happen automatically but is not in the software yet). Right now we have a template script set up to help with that for the record:

1. Make the 'wrapper' div for the banner (in this case siteNoticeWrapper ) display:none.
2. Add {{MediaWiki:CentralNoticeHideBanner.js}} to the bottom of the banner code.
3. Save (After saving you may need to refresh the page again as well).
4. Fill out the new variables that popped up:
4a. hide-cookie-div - the name of the wrapper div (in this case siteNoticeWrapper ) 
4b. hide-cookie-name - the name of the cookie you want to use (could be the same as another emergency banner for example)
4c. hide-cookie-expire - Expiry length, in days
5. Make the close button onclick="mw.centralNotice.bannerData.hideBanner()"
6. Save

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links