Last modified: 2014-02-19 18:03:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55106, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53106 - Wikibase API does not integrate with AssertEdit extension
Wikibase API does not integrate with AssertEdit extension
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
: 53147 (view as bug list)
Depends on:
Blocks: repoapi
  Show dependency tree / graph
 
Reported: 2013-08-20 18:23 UTC by Aude
Modified: 2014-02-19 18:03 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2013-08-20 18:23:09 UTC 
The AssertEdit extension (deployed on wikidata and other wmf wikis) adds the assert param to the api edit modules to help ensure bots do not edit logged out and other such stuff.

Wikibase api modules, however, do not recognize the assert param.  

AssertEdit uses the APIEditBeforeSave hook in ApiEditPage.  It also uses APIGetParamDescription and APIGetAllowedParams which are in ApiBase.
Comment 1 Addshore 2013-08-21 09:12:36 UTC 
*** Bug 53147 has been marked as a duplicate of this bug. ***
Comment 2 Kunal Mehta (Legoktm) 2013-10-21 04:22:21 UTC 
The current implementation at https://gerrit.wikimedia.org/r/#/c/90263/ would address this bug.
Comment 3 Gerrit Notification Bot 2014-01-06 08:11:24 UTC 
Change 90263 had a related patch set uploaded by Legoktm:
Merge AssertEdit extension into core

https://gerrit.wikimedia.org/r/90263
Comment 4 Gerrit Notification Bot 2014-01-06 18:55:37 UTC 
Change 90263 merged by jenkins-bot:
Merge AssertEdit extension into core

https://gerrit.wikimedia.org/r/90263
Comment 5 Bartosz Dziewoński 2014-01-06 20:53:26 UTC 
So this is fixed too, I guess.
Comment 6 Lydia Pintscher 2014-02-18 13:59:06 UTC 
Adam says it is not fixed yet.
Comment 7 Addshore 2014-02-18 14:00:03 UTC 
Reopened as although this is merged in core the wikibase api modules still appear not to use it
Comment 9 Addshore 2014-02-19 18:03:00 UTC 
Ah! it just doesn't show up in the module documentation!
Of course as its now available for ALLLLL of the modules :>
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links