Last modified: 2013-09-27 16:19:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55085, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 53085 - No forcehttps cookies for sister projects on AutoLogin


Summary:	No forcehttps cookies for sister projects on AutoLogin

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	CentralAuth (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Chris Steipp

URL:
Whiteboard:
Keywords:

Depends on:	53536 53538
Blocks:
	Show dependency tree / graph

Reported:	2013-08-20 03:17 UTC by Chris Steipp
Modified:	2013-09-27 16:19 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chris Steipp 2013-08-20 03:17:28 UTC

When logging in, and wgSecureLogin is used, the forceHTTPS cookie (to have mediawiki redirect to https from an http call) isn't set for all SUL domains, only the project where the user is logging in.

Need to add the forceHTTPS cookie, probably in the same place where we set the token cookie.

Comment 1 Gerrit Notification Bot 2013-08-28 22:37:53 UTC

Change 81591 had a related patch set uploaded by CSteipp:
Set forceHTTPS cookies for Autologin wikis

https://gerrit.wikimedia.org/r/81591

Comment 2 Gerrit Notification Bot 2013-08-28 22:41:37 UTC

Change 81591 merged by jenkins-bot:
Set forceHTTPS cookies for Autologin wikis

https://gerrit.wikimedia.org/r/81591

Comment 3 Chris Steipp 2013-08-28 23:46:32 UTC

That patch only sets the cookies. Still need to clean up from them on logout, which requires touching every wiki. That will be a more complex patch.

Comment 4 Chris Steipp 2013-08-29 15:47:08 UTC

Second half of the patch was added as a bug by Seb35. Probably good to keep this as a tracking bug, and that one for the specific issue.

Comment 5 Seb35 2013-08-29 16:27:07 UTC

I also opened the bug 53538 which can be considered as an other specific issue due to the fact wgCookiePrefix is language-specific.

Comment 6 Brad Jorsch 2013-09-27 16:19:44 UTC

Since this seems to be fixed, and the dependent bugs too, let's close this now. Feel free to reopen if I'm mistaken.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links